[upnp-sdk-dev] Re: release 1.3.1, rpm, ixmlPrintDocument

[John D. <jd...@re...>]

On Tue, 2006-03-07 at 22:42 +0100, Eric Tanguy wrote:
> John, the rpms for release 1.3.1 are already built for FC-3, FC-4 and
> devel as well as new version of ushare using it. If you want to own the
> package or submit a patch, don't hesitate! The only thing is that this
> lib have to be compliant with ushare (the package which need it and
> that's why i did rpm for libupnp). Another question : redhat will
> include it in core or prefer to let it in extras ?

Excellent Eric! You're one step ahead of me again. The rpm looks
fabulous. The only thing that appears to be missing is the documentation
and sample programs. These should probably go
in /usr/share/doc/libupnp-*

I don't think auto generated doc is terribly important, it would be nice
but not critical, but I do think including UPnP_Programming_Guide.pdf is
essential. 

Off the top of my head without any testing (I feel like I'm going to
regret my caviler suggestions which weren't tested :-) Something like
this should do the trick (Remi: since these seem to be tweaks to the
configure stuff perhaps it should be added at your end, or you may
prefer a different approach):

% in configure.ac add:

AC_ARG_WITH([docdir], AC_HELP_STRING([--with-docdir=DIR],
			             [where documentation is installed]),
            [docdir="$with_docdir"],
            [docdir="${datadir}/doc/${PACKAGE_NAME}-${PACKAGE_VERSION}"])

AC_SUBST(docdir)

% in upnp/doc/Makefile.am add:

docdir = @DOCDIR@
doc_DATA = UPnP_Programming_Guide.pdf

% in upnp/Makefile.am add:

docdir = @DOCDIR@
examplesdir = $(docdir)/examples
examples_DATA =  $(upnp_tv_ctrlpt_SOURCES) $(upnp_tv_device_SOURCES)

(Note: examples_DATA probably also needs a Makefile utilizing
pkg-config)

Once all this is done Eric then I think all that needs to be done is to
just add the doc files to the %files section in the spec file.

If either of you prefers I do the work I'm happy to.

With respect to moving libupnp from extras to core that's a decision
which will be out there in the future a bit. At the moment our use of
this technology is experimental and not yet fundamental to the core
product (all of which is subject to change :-)


-- 
John Dennis <jd...@re...>
Red Hat Inc.