From: D B. <ba...@aw...> - 2017-11-13 15:00:41
|
Hi, I noticed that Unity IDM offers not only English but also a Polish as configurable language. Are there plans for supporting more languages or does this have low priority for the dev team? I'm asking because I'm wondering if there's a way to give back to this useful project and I thought I could e.g. do a German language translation - if that's useful to you. Is it useful and would you accept contributions from outside your core team? Cheers, D. |
From: Krzysztof B. <kb...@un...> - 2017-11-13 19:15:53
|
Hi, W dniu 13.11.2017 o 16:00, D Baum pisze: > Hi, > > I noticed that Unity IDM offers not only English but also a Polish as > configurable language. Are there plans for supporting more languages or > does this have low priority for the dev team? > > I'm asking because I'm wondering if there's a way to give back to this > useful project and I thought I could e.g. do a German language > translation - if that's useful to you. > > Is it useful and would you accept contributions from outside your core team? Sure - it is open source ;-) We have already DE flag included, so "only" the messages are missing. I think a complete translation (i.e. including Admin UI, which has by far the largest amount of messages) is not that critical, but end-user facing translation would be very welcome. This way the PL translation is done, so creating counterparts whenever there are messages_pl.properties will be (by far) enough. Thanks, Krzysztof PS: The short list of contributors shown by GitHub is incomplete. After migrating to Gihub only people who contributed in the original Assembla repo and at the same time have Github account with the same email are listed. What means: Bernd. |
From: D B. <ba...@aw...> - 2018-02-09 16:08:45
|
Hi, it took longer than I hoped but I've just now sent the pull request for the German translation (https://github.com/unity-idm/unity/pull/11). As you recommended, I've translated all variables present in Polish (from English to German). Note that there are two files the Polish translation that contain variables not present in the English one. I didn't quite know what to do with those... web-common/src/main/resources/messages/webui/messages.properties missing RegistrationRequestEditorDialog.submitAndAccept RegistrationRequest.requestedIdentity RegistrationRequest.requestId RegistrationRequest.status RegistrationRequest.submitTime RequestsComponent.caption web-admin/src/main/resources/messages/webhome/messages.properties missing IdentityDetails.identityLocal IdentityDetails.identityLocalConfirmed IdentityDetails.identityLocalNotConfirmed IdentityDetails.identityLocalNotConfirmedWithRequest IdentityDetails.identityRemote HTH D. PS: "credentials" is a PITA to translate into German (when it refers to both passwords and certificates). On 13/11/17 20:15, Krzysztof Benedyczak wrote: > Hi, > > W dniu 13.11.2017 o 16:00, D Baum pisze: >> Hi, >> >> I noticed that Unity IDM offers not only English but also a Polish as >> configurable language. Are there plans for supporting more languages or >> does this have low priority for the dev team? >> >> I'm asking because I'm wondering if there's a way to give back to this >> useful project and I thought I could e.g. do a German language >> translation - if that's useful to you. >> >> Is it useful and would you accept contributions from outside your core >> team? > > Sure - it is open source ;-) > > We have already DE flag included, so "only" the messages are missing. > > I think a complete translation (i.e. including Admin UI, which has by > far the largest amount of messages) is not that critical, but end-user > facing translation would be very welcome. This way the PL translation is > done, so creating counterparts whenever there are messages_pl.properties > will be (by far) enough. > > Thanks, > Krzysztof > > > PS: The short list of contributors shown by GitHub is incomplete. After > migrating to Gihub only people who contributed in the original Assembla > repo and at the same time have Github account with the same email are > listed. What means: Bernd. |
From: Krzysztof B. <kb...@un...> - 2018-02-11 21:06:46
|
Hi, First of all big thanks for this - needless to say - huge contribution, it is very welcomed! I'll merge it into main development branch and will be released in the next (2.5.0) feature version. Regarding your doubts: W dniu 09.02.2018 o 16:50, D Baum pisze: > Note that there are two files the Polish translation that contain > variables not present in the English one. I didn't quite know what to do > with those... > > web-common/src/main/resources/messages/webui/messages.properties > missing > RegistrationRequestEditorDialog.submitAndAccept > RegistrationRequest.requestedIdentity > RegistrationRequest.requestId > RegistrationRequest.status > RegistrationRequest.submitTime > RequestsComponent.caption With one exception those messages are only used in Admin UI, and were moved there. PL versions were left behind, what of course was not a big problem, but I'll remove them to eliminate the confusion. > web-admin/src/main/resources/messages/webhome/messages.properties > missing > IdentityDetails.identityLocal > IdentityDetails.identityLocalConfirmed > IdentityDetails.identityLocalNotConfirmed > IdentityDetails.identityLocalNotConfirmedWithRequest > IdentityDetails.identityRemote Those were some legacy ones, not used anymore. I'll remove them too. Thank you again! Krzysztof PS - fix for your SAML bug is just being released in 2.4.1. |