From: Sander A. <sa....@fz...> - 2022-09-08 11:04:53
Attachments:
smime.p7s
|
Hi Krzysztof, hi Roman, We got one "bug report" and one usability enhancement from users which I want to share with you. If a user sends an invitation into a subgroup of a project to an collaborator who is already member of another subgroup of this project and the collaborator accepts the invitation, the collaborator is removed from the previous subgroup. I don't know if this is intended by you, but I assume most users won't expect this behaviour. Especially in large projects with many users and subgroups it might be difficult to check if the invited person is already member of another subgroup. The usability enhancement is about resending invitations. Resending is only possible if the invitation is still valid. The user asked if it wouldn't be possible to resend them even if they are invalid and set a new expiration date Best regards, Sander -- Federated Systems and Data Juelich Supercomputing Centre phone: +49 2461 61 8847 fax: +49 2461 61 6656 email: sa....@fz... ----------------------------------------------------------------------- ----------------------------------------------------------------------- Forschungszentrum Juelich GmbH 52425 Juelich Sitz der Gesellschaft: Juelich Eingetragen im Handelsregister des Amtsgerichts Dueren Nr. HR B 3498 Vorsitzender des Aufsichtsrats: MinDir Volker Rieke Geschaeftsfuehrung: Prof. Dr.-Ing. Wolfgang Marquardt (Vorsitzender), Karsten Beneke (stellv. Vorsitzender), Prof. Dr. Astrid Lambrecht, Prof. Dr. Frauke Melchior ----------------------------------------------------------------------- ----------------------------------------------------------------------- |
From: Krzysztof B. <kb...@un...> - 2022-09-09 08:55:30
|
Hi Sander, W dniu 8.09.2022 o 13:04, Sander Apweiler pisze: > Hi Krzysztof, > hi Roman, > > We got one "bug report" and one usability enhancement from users which > I want to share with you. > > If a user sends an invitation into a subgroup of a project to an > collaborator who is already member of another subgroup of this project > and the collaborator accepts the invitation, the collaborator is > removed from the previous subgroup. I don't know if this is intended by > you, but I assume most users won't expect this behaviour. Especially in > large projects with many users and subgroups it might be difficult to > check if the invited person is already member of another subgroup. We are currently testing bigger upman refresh, will check that issue as well. > The usability enhancement is about resending invitations. Resending is > only possible if the invitation is still valid. The user asked if it > wouldn't be possible to resend them even if they are invalid and set a > new expiration date > Should be doable, will open a ticket on that. Best, Krzysztof |
From: Krzysztof B. <kb...@un...> - 2022-09-29 15:18:30
|
Hi Sander, Coming back to those issues W dniu 8.09.2022 o 13:04, Sander Apweiler pisze: > If a user sends an invitation into a subgroup of a project to an > collaborator who is already member of another subgroup of this project > and the collaborator accepts the invitation, the collaborator is > removed from the previous subgroup. I don't know if this is intended by > you, but I assume most users won't expect this behaviour. Especially in > large projects with many users and subgroups it might be difficult to > check if the invited person is already member of another subgroup. Yes, we can confirm that. 1. Why this happens? The enquiry form which is used to invite an existing Unity user to a new project/group is set to be sticky. Sticky forms needs to be actively launched, are never shown automatically by Unity. Sticky forms also allow for modifying existing state of user's account, this is in fact "edit yourself" form. Non-sticky forms are collecting data which should be added to existing account. Now the form called by default <SomeProject>JoinEnquiry is set to be sticky as it can be enabled in HomeUI, so that users can apply for membership on their own (i.e. w/o invitation). Non sticky form would appear for each user entering any Unity endpoint. And as you noticed this is causing edit of the account, and overwriting user's groups when used in the by invitation flow. 2. Workaround. *If you don't use the feature to allow users to request project membership from HomeUI*, it should be possible to quickly fix the problem. Just in the ...JoinEnquiry form change two settings: i.e. make it non sticky and by invitation only. This will allow to invite users but the groups overwriting will disappear. 3. We are thinking about a proper solution, working also in the case when self-requested membership is enabled. Will keep you informed. Most likely this won't make it into the next release though. > The usability enhancement is about resending invitations. Resending is > only possible if the invitation is still valid. The user asked if it > wouldn't be possible to resend them even if they are invalid and set a > new expiration date > That was fixed, will be released in 3.11, coming out soon. Best, Krzysztof |
From: Krzysztof B. <kb...@un...> - 2022-09-29 16:01:29
|
Sander, A correction :-) W dniu 29.09.2022 o 17:18, Krzysztof Benedyczak pisze: > Hi Sander, > > Coming back to those issues > > W dniu 8.09.2022 o 13:04, Sander Apweiler pisze: >> If a user sends an invitation into a subgroup of a project to an >> collaborator who is already member of another subgroup of this project >> and the collaborator accepts the invitation, the collaborator is >> removed from the previous subgroup. I don't know if this is intended by >> you, but I assume most users won't expect this behaviour. Especially in >> large projects with many users and subgroups it might be difficult to >> check if the invited person is already member of another subgroup. > > Yes, we can confirm that. > > 1. Why this happens? The enquiry form which is used to invite an > existing Unity user to a new project/group is set to be sticky. Sticky > forms needs to be actively launched, are never shown automatically by > Unity. Sticky forms also allow for modifying existing state of user's > account, this is in fact "edit yourself" form. Non-sticky forms are > collecting data which should be added to existing account. > > Now the form called by default <SomeProject>JoinEnquiry is set to be > sticky as it can be enabled in HomeUI, so that users can apply for > membership on their own (i.e. w/o invitation). Non sticky form would > appear for each user entering any Unity endpoint. And as you noticed > this is causing edit of the account, and overwriting user's groups > when used in the by invitation flow. > > 2. Workaround. *If you don't use the feature to allow users to request > project membership from HomeUI*, it should be possible to quickly fix > the problem. Just in the ...JoinEnquiry form change two settings: > > i.e. make it non sticky and by invitation only. This will allow to > invite users but the groups overwriting will disappear. > > 3. We are thinking about a proper solution, working also in the case > when self-requested membership is enabled. Will keep you informed. > Most likely this won't make it into the next release though. > I was just made aware by my colleague that what is above is only partially correct. Or better said it is correct, but after some (IMHO unlikely) reconfiguration of the default enquiry forms. Sorry for the noise! After joint session with my colleague, it seems that we have troubles reproducing this issuey. Can you please describe the scenario more closely? What is the setup of projects and (if used) sub projects? What ways to invite are used? We have run bunch of tests here and all were working fine. The only reproduction which we were able to have was in so unlikely situation that I even won't waste your time describing it... Thank you, Krzysztof |
From: Sander A. <sa....@fz...> - 2022-10-13 09:55:26
Attachments:
smime.p7s
|
Hi Krzysztof, sorry for the delay. The project allows and uses sub-projects. There are only registration forms and sign-up enquiries configured. Both are available by invitation only. We do not have membership update enquiries configured. Do you need the full forms? Best regards, Sander On Thu, 2022-09-29 at 18:01 +0200, Krzysztof Benedyczak wrote: > Sander, > > A correction :-) > > W dniu 29.09.2022 o 17:18, Krzysztof Benedyczak pisze: > > > Hi Sander, > > > > Coming back to those issues > > > > W dniu 8.09.2022 o 13:04, Sander Apweiler pisze: > > > > > If a user sends an invitation into a subgroup of a project to an > > > collaborator who is already member of another subgroup of this > > > project > > > and the collaborator accepts the invitation, the collaborator is > > > removed from the previous subgroup. I don't know if this is > > > intended by > > > you, but I assume most users won't expect this behaviour. > > > Especially in > > > large projects with many users and subgroups it might be > > > difficult to > > > check if the invited person is already member of another > > > subgroup. > > Yes, we can confirm that. > > 1. Why this happens? The enquiry form which is used to invite an > > existing Unity user to a new project/group is set to be sticky. > > Sticky forms needs to be actively launched, are never shown > > automatically by Unity. Sticky forms also allow for modifying > > existing state of user's account, this is in fact "edit yourself" > > form. Non-sticky forms are collecting data which should be added to > > existing account. > > > > Now the form called by default <SomeProject>JoinEnquiry is set to > > be sticky as it can be enabled in HomeUI, so that users can apply > > for membership on their own (i.e. w/o invitation). Non sticky form > > would appear for each user entering any Unity endpoint. And as you > > noticed this is causing edit of the account, and overwriting user's > > groups when used in the by invitation flow. > > 2. Workaround. *If you don't use the feature to allow users to > > request project membership from HomeUI*, it should be possible to > > quickly fix the problem. Just in the ...JoinEnquiry form change two > > settings: > > i.e. make it non sticky and by invitation only. This will allow to > > invite users but the groups overwriting will disappear. > > 3. We are thinking about a proper solution, working also in the > > case when self-requested membership is enabled. Will keep you > > informed. Most likely this won't make it into the next release > > though. > I was just made aware by my colleague that what is above is only > partially correct. Or better said it is correct, but after some (IMHO > unlikely) reconfiguration of the default enquiry forms. Sorry for the > noise! > After joint session with my colleague, it seems that we have troubles > reproducing this issuey. Can you please describe the scenario more > closely? What is the setup of projects and (if used) sub projects? > What ways to invite are used? We have run bunch of tests here and all > were working fine. The only reproduction which we were able to have > was in so unlikely situation that I even won't waste your time > describing it... > Thank you, > Krzysztof > -- Federated Systems and Data Juelich Supercomputing Centre phone: +49 2461 61 8847 fax: +49 2461 61 6656 email: sa....@fz... ----------------------------------------------------------------------- ----------------------------------------------------------------------- Forschungszentrum Juelich GmbH 52425 Juelich Sitz der Gesellschaft: Juelich Eingetragen im Handelsregister des Amtsgerichts Dueren Nr. HR B 3498 Vorsitzender des Aufsichtsrats: MinDir Volker Rieke Geschaeftsfuehrung: Prof. Dr.-Ing. Wolfgang Marquardt (Vorsitzender), Karsten Beneke (stellv. Vorsitzender), Prof. Dr. Astrid Lambrecht, Prof. Dr. Frauke Melchior ----------------------------------------------------------------------- ----------------------------------------------------------------------- |
From: Krzysztof B. <kb...@un...> - 2022-10-17 10:51:27
|
Hi Sander, W dniu 13.10.2022 o 11:55, Sander Apweiler pisze: > Hi Krzysztof, > sorry for the delay. > > The project allows and uses sub-projects. There are only registration > forms and sign-up enquiries configured. Both are available by > invitation only. We do not have membership update enquiries configured. > > Do you need the full forms? If default forms are used then no. If some non-presentational (if you only updated some label or image that doesn't matter) changes were made then yes. But what is even more important is detailed description of the scenario. I was asking about sub projects, as with sub-projects the range of possible scenarios is bigger, and most likely we haven't tried the one you are hitting. So please provide the details of: 0. starting structure of (relevant) project(s) and subproject(s) 1. the starting situation of a user (member of what groups? attributes?) 2. what invitation is sent and how it is accepted 3. what happens in the end (i.e. what is the problem) Thank you, Krzysztof |