Menu

#662 sp_cmt_cpp_doxygen doesn't work for //@

Future
fixed
None
5
2016-03-22
2016-02-04
No

Doxygen's //@ isn't covered by sp_cmt_cpp_doxygen.

Discussion

  • Anonymous

    Anonymous - 2016-02-04
     
  • Guy Maurel

    Guy Maurel - 2016-02-08

    Can you push a config file, an example and what you expect to get?

     
  • Anonymous

    Anonymous - 2016-02-08

    I've already sent Ben the attached patch by email.

    This is the example code (doxygen grouping comments after the foos):

    ///foo
    ///<foo
    //!foo
    //!<foo
    
    //@{
    //@}
    
    ///@{
    ///@}
    
    //!@{
    //!@}
    

    The config file contains:

    sp_cmt_cpp_start = add
    sp_cmt_cpp_doxygen = true
    

    sp_cmt_cpp_doxygen is supposed to keep doxygen comments intact which it does for lines 1 to 4, but the grouping comments get ripped apart:

    /// foo
    ///< foo
    //! foo
    //!< foo
    
    // @{
    // @}   
    
    /// @{
    /// @}
    
    //! @{
    //! @}
    

    With the attached patch, grouping comments are handled correctly, too:

    /// foo
    ///< foo
    //! foo
    //!< foo
    
    //@{
    //@}
    
    ///@{
    ///@}
    
    //!@{
    //!@}
    
     

    Last edit: Anonymous 2016-02-08
  • Guy Maurel

    Guy Maurel - 2016-02-20

    Your patch runs pretty well.
    I'll integrate it soon.
    Thanks

     
  • Guy Maurel

    Guy Maurel - 2016-02-24

    pushed at f19064b..a724a42 on 2016-02-24 17:49

     
  • Anonymous

    Anonymous - 2016-02-24

    Would have been very nice if you had used the git patch I've sent you so that the committing author and commit message wouldn't have been lost! :-(

     
  • Ben Gardner

    Ben Gardner - 2016-03-18
    • status: open --> fixed
     
  • Guy Maurel

    Guy Maurel - 2016-03-22
    • assigned_to: Guy Maurel
     
MongoDB Logo MongoDB