Thread: [Ummon-devel] Reduced size

SourceForge Headquarters 1320 Columbia Street Suite 310 San Diego, CA 92101 +1 (858) 422-6466

Alright, since it blocked my 40k+ post earlier, and i replied about my
program before it got up...here is a repost of a smaller size.  I guess Miro
didn't feel like approving it.

-Corey

> Alright, since it blocked my 40k+ post earlier, and i replied about my
> program before it got up...here is a repost of a smaller size.  I guess
Miro
> didn't feel like approving it.
I was on a wedding this weekend so I have just read this note :)

I have checked the source and the program. Program worked almost
flawless (it has few bugs), but I couldn't compile the code!

For instance Skipcomment function is empy. Did you sent me some old -
unfinshed
version of the code?

 What compiler are you using ?
I had to replace fnsplit (and other similar calls) with _splitpath, ...  to
work on Visual C++.

Comments are also always appreciated :)

Could you please send me latest version of the code and then I will try to
port it to Visual
and suggest some improvements.

Regards,
    Miro

Alright, Miro, my fault.  It seems my code wasn't completely Standard C.
Guess will have to write a function for that or something.

Oh, yes, I did forget to finish the skip over c style comments in that
function.  Darn, not finished.

-Corey
----- Original Message -----
From: "Miroslav Rajcic" <mir...@in...>
To: "Ummon mailing list" <umm...@li...>
Sent: Thursday, September 07, 2000 10:39 AM
Subject: Re: [Ummon-devel] Reduced size

: > Alright, since it blocked my 40k+ post earlier, and i replied about my
: > program before it got up...here is a repost of a smaller size.  I guess
: Miro
: > didn't feel like approving it.
: I was on a wedding this weekend so I have just read this note :)
:
: I have checked the source and the program. Program worked almost
: flawless (it has few bugs), but I couldn't compile the code!
:
: For instance Skipcomment function is empy. Did you sent me some old -
: unfinshed
: version of the code?
:
:  What compiler are you using ?
: I had to replace fnsplit (and other similar calls) with _splitpath, ...
to
: work on Visual C++.
:
: Comments are also always appreciated :)
:
: Could you please send me latest version of the code and then I will try to
: port it to Visual
: and suggest some improvements.
:
: Regards,
:     Miro
:
:
: _______________________________________________
: Ummon-devel mailing list
: Umm...@li...
: http://lists.sourceforge.net/mailman/listinfo/ummon-devel
:

Yea, I figured there would be more feature requests later, but I did what
was requested and needed at the moment.
1) Tabs surviving....thanks for finding that, I didn't see it.
2) Object oriented code?  Don't make me shoot you like the Israeli who wrote
Astyle.  This is a good place for standard C.
3) I replaced fnsplit, fnmerge with _splitpath _makepath
4) Keeps adding, and the bad tabbing....i need the file you tested that on.

Extra features:
Keep em coming.
1) .old files...i had em saved before, but I find no reason to save them
now, if we are just formatting the code for release and use.  But, if you
want to delete all those files yourself...I won't delete them.
2) Subs, Ok, should this be a standard feature?  Or a param?
3)  ini file....um, is this going to be windows only?  If not, i don't feel
like writing extra code for nothing.

I am not making a VC++ Project for this, I am just writing in C.  You can do
whatever you want this with, vc++ gives me trouble.

-Corey
----- Original Message -----
From: "Miroslav Rajcic" <mir...@in...>
To: "C" <co...@ac...>
Sent: Sunday, September 10, 2000 6:26 PM
Subject: Re: [Ummon-devel] Reduced size

: > Alright, Miro, my fault.  It seems my code wasn't completely Standard C.
: > Guess will have to write a function for that or something.
: I have made the port to VC++ (se attachment), but there are still bugs in
: there.
:
: Take a look at the list of my ideas:
:
: BUGS:
: - it keeps adding one more "}" char each time I start program
:    on the same file
: - some tab indents are converted into 8 spaces (with tab = 4 spaces)
: - some tab indents are converted into 0 spaces (with tab = 4 spaces)
: - code should be object oriented
: - code should be more clear and have more comments
: - each tab must be transformed (I have found cases where tabs survived)
:
: FEATURES:
: - search also into subdirectories
: - program should preserve original files as "*.old" (not to delete it)
:   perhaps in same dir (or in other given directory)
: - Windows version: use of ini files to store parameters
: -
:
:
: I am sure I'll think more, but no time now. BTW would you like us to do it
: together ? It mignh be easier (I imagine this program to be pretty big and
: loaded with features).
:

Oh yes, just to clear this up.  I am just writing/debugging the code right
now.  It will get cleaned up later.

-Corey
----- Original Message -----
From: "C" <co...@ac...>
To: "ummonlist" <umm...@li...>
Sent: Monday, September 11, 2000 1:36 AM
Subject: Re: [Ummon-devel] Reduced size

: Yea, I figured there would be more feature requests later, but I did what
: was requested and needed at the moment.
: 1) Tabs surviving....thanks for finding that, I didn't see it.
: 2) Object oriented code?  Don't make me shoot you like the Israeli who
wrote
: Astyle.  This is a good place for standard C.
: 3) I replaced fnsplit, fnmerge with _splitpath _makepath
: 4) Keeps adding, and the bad tabbing....i need the file you tested that
on.
:
: Extra features:
: Keep em coming.
: 1) .old files...i had em saved before, but I find no reason to save them
: now, if we are just formatting the code for release and use.  But, if you
: want to delete all those files yourself...I won't delete them.
: 2) Subs, Ok, should this be a standard feature?  Or a param?
: 3)  ini file....um, is this going to be windows only?  If not, i don't
feel
: like writing extra code for nothing.
:
:
: I am not making a VC++ Project for this, I am just writing in C.  You can
do
: whatever you want this with, vc++ gives me trouble.
:
: -Corey
: ----- Original Message -----
: From: "Miroslav Rajcic" <mir...@in...>
: To: "C" <co...@ac...>
: Sent: Sunday, September 10, 2000 6:26 PM
: Subject: Re: [Ummon-devel] Reduced size
:
:
: : > Alright, Miro, my fault.  It seems my code wasn't completely Standard
C.
: : > Guess will have to write a function for that or something.
: : I have made the port to VC++ (se attachment), but there are still bugs
in
: : there.
: :
: : Take a look at the list of my ideas:
: :
: : BUGS:
: : - it keeps adding one more "}" char each time I start program
: :    on the same file
: : - some tab indents are converted into 8 spaces (with tab = 4 spaces)
: : - some tab indents are converted into 0 spaces (with tab = 4 spaces)
: : - code should be object oriented
: : - code should be more clear and have more comments
: : - each tab must be transformed (I have found cases where tabs survived)
: :
: : FEATURES:
: : - search also into subdirectories
: : - program should preserve original files as "*.old" (not to delete it)
: :   perhaps in same dir (or in other given directory)
: : - Windows version: use of ini files to store parameters
: : -
: :
: :
: : I am sure I'll think more, but no time now. BTW would you like us to do
it
: : together ? It mignh be easier (I imagine this program to be pretty big
and
: : loaded with features).
: :
:
: _______________________________________________
: Ummon-devel mailing list
: Umm...@li...
: http://lists.sourceforge.net/mailman/listinfo/ummon-devel
:

> 1) .old files...i had em saved before, but I find no reason to save them
> now, if we are just formatting the code for release and use.  But, if you
> want to delete all those files yourself...I won't delete them.
The reason to do that is that user might not trust the program
not to eat some part of its code. That might be some flag option (to keep or
not to keep old files).

> 2) Subs, Ok, should this be a standard feature?  Or a param?
Param :)

> 2) Object oriented code?  Don't make me shoot you like the Israeli who
wrote
> Astyle.  This is a good place for standard C.
> 3)  ini file....um, is this going to be windows only?  If not, i don't
feel
> like writing extra code for nothing.
> I am not making a VC++ Project for this, I am just writing in C.  You can
do
> whatever you want this with, vc++ gives me trouble.

OK, do what you feel best, but in my opinion ;) program must have code
flexible enough to easily add new features (I like to see code done in
layers
where each new layer - class inheritance adds another functionality on top
of previous one).
I am imagining the code to be able to:
- convert to/from unix format (CR/LF<->LF)
- eat trailing whitespace (I hope you done that, havent tested)
- support for beautifier styles (see astyle documentation) - far future :0)

Regarding ini file it might be good to use it since you would type bunch of
params each time on command line (if not using script).
One tip: Ummon project has portable ini file class (uses STL library), it
also has file enumeration
code. This is good chance to see how it works / debug it for rest of us.

> 4) Keeps adding, and the bad tabbing....i need the file you tested that
on.
Test file I used is OutlookView.cpp from WinUmmon (take a notice
on those message map entries after formatting)