Menu

#4 Animation Frame Interpolation Patch

svn
open
nobody
None
5
2021-09-21
2021-09-20
No

This adds animation frame interpolation (no pos/rot or shadows) and it is loosely based on what is found here for quake.

1 Attachments

Discussion

  • Mattias Cibien

    Mattias Cibien - 2021-09-20

    If accepted I can continue to work on this providing both pos/rot and shadows.

     
  • Ozkan Sezer

    Ozkan Sezer - 2021-09-20

    Some pedantry:

    • No author name comments: they are ugly, not a big fan. Instead,
      we usually give credit in docs/AUTHORS file.

    • The new cvar is defined wrong: the last field is not a boolean
      but a flag, so it should be CVAR_ARCHIVE, not true.

    • When checking a cvar's value as a boolean we use it's 'integer'
      member instead of 'value' when possible.

    • Newly added 'Blended' procedures and the lastpose0 var should be
      static to gl_rmain.c.

    • Additions to entity_t structure should be guarded by GLQUAKE
      because the patch only touches OpenGL path.

    • Whitespace style should match other places.

    Attached a revised patch which does the above changes.

    Question: Have you extensively tested the patch in the whole game
    in all episodes and maps, including the Portal of Praevus mission
    pack? IIRC, this functionality can be a tricksy one.

     
  • Mattias Cibien

    Mattias Cibien - 2021-09-21

    Here is the new patch with the modifications you asked.

    Regarding testing: this was merely an excercise to explain frame interpolation to a collague so it was not exensively tested but I'll do my best to test it thorugh the game and the expansion.

     
  • Ozkan Sezer

    Ozkan Sezer - 2021-09-21

    but I'll do my best to test it thorugh the game and the expansion.

    Yes please.

    (BTW, your v2-patch still has some of the pedantic issues:
    The one I attached above has things right.)

     
  • Mattias Cibien

    Mattias Cibien - 2021-09-21

    Ok. I'll adjust the patch

     
  • Steven

    Steven - 2021-09-21

    Awesome matey, thanks. Ozkan's 0001 patch works fine for me on my Mac.

     

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.