Menu

#62 software renderers will crash at map start

1.5.x
closed-fixed
nobody
None
5
2016-04-11
2016-04-11
No

software renderers compiled from source crash at map start because of snext and tnext being uninitialized in d_sky.c. giving them a value fixes the problem

Discussion

  • Ozkan Sezer

    Ozkan Sezer - 2016-04-11

    Does this happen if you compile using Visual Studio?
    I get no crashes using gcc: do my builds crash for you?

    As for the solution you are suggesting: Around line 75
    of d_sky.c, initializing snext and tnext to 0 fixes the
    issue, correct?

     
  • MilkeyWilkey

    MilkeyWilkey - 2016-04-11

    yes, in visual studio 2010
    yes, I initialized them as 0 right after sstep and tstep

     
  • MilkeyWilkey

    MilkeyWilkey - 2016-04-11

    h2.exe build from latest release works fine.
    btw, which h2.exe it is? there is h2 asm, h2 noasm and h2 mgl4 compiled from source

     
  • Ozkan Sezer

    Ozkan Sezer - 2016-04-11

    yes, in visual studio 2010

    OK, I see. Did you install any service packs to it?
    (IIRC, there is a SP1 to VS2010.)

    h2.exe build from latest release works fine.

    So it is probably an MSVC issue.

    btw, which h2.exe it is?
    there is h2 asm, h2 noasm and h2 mgl4 compiled from source

    The h2.exe from the release build should correspond to h2-mgl4.
    The h2-compat.exe should correspond to h2-noasm.

     
  • MilkeyWilkey

    MilkeyWilkey - 2016-04-11

    sp1 installed. it will not compile without it

     
  • Ozkan Sezer

    Ozkan Sezer - 2016-04-11

    OK then. Will push a fix to the svn repo shortly.

     
  • Ozkan Sezer

    Ozkan Sezer - 2016-04-11

    The issue should be fixed as of svn rev. 5545:
    https://sourceforge.net/p/uhexen2/code/5545/

    Closing as fixed.

     
  • Ozkan Sezer

    Ozkan Sezer - 2016-04-11
    • status: open --> closed-fixed
     

Log in to post a comment.