#58 Items dropping issues

[MilkeyWilkey]

1) If you select an item in the inventory, you cannot drop it until the inventory screen disappears. Until it happens you will drop previously selected item. since there is no way to speed up the process, the transfer of items to your frends in the coop can became very tedious process
2) dropped items produce loud barrel crack sound. that should not happen at all

[Jonathan Bergeron]

for bug #1

I found that calling Inv_Update(true); in InvLeft_f and InvRight_f right before the end of the "if (inv_flg)" block fixed the bug

It is a very annoying bug when playing coop

Here's what the functions would look like:

static void InvLeft_f(void)
{
if (!cl.inv_count || cl.intermission)
return;

if (inv_flg)
{
    // scroll inventory icons if we're at the left-most already
    if (cl.inv_selected == cl.inv_startpos)
    {
        cl.inv_startpos = (cl.inv_startpos - 1 + cl.inv_count) % cl.inv_count;
        cl.inv_selected = cl.inv_startpos;
    }
    else
    {
        cl.inv_selected = (cl.inv_selected - 1 + cl.inv_count) % cl.inv_count;
    }

    if (scr_viewsize.integer < 100)
        scr_fullupdate = 0;

    Inv_Update(true);
}
else
{
    inv_flg = true;
}
S_LocalSound("misc/invmove.wav");
InventoryHideTime = cl.time+INVENTORY_DISPLAY_TIME;

}

static void InvRight_f(void)
{
int right_icon;

if (!cl.inv_count || cl.intermission)
    return;

if (inv_flg)
{

    if (cl.inv_count >= INV_MAX_ICON)
        right_icon = (cl.inv_startpos + INV_MAX_ICON - 1) % cl.inv_count;
    else
        right_icon = (cl.inv_startpos + cl.inv_count - 1) % cl.inv_count;
    // scroll inventory icons if we're at the right most already
    if (cl.inv_selected == right_icon)
        cl.inv_startpos = (cl.inv_startpos + 1) % cl.inv_count;

    cl.inv_selected = (cl.inv_selected + 1) % cl.inv_count;

    if (scr_viewsize.integer < 100)
        scr_fullupdate = 0;

    Inv_Update(true);
}
else
{
    inv_flg = true;
}
S_LocalSound("misc/invmove.wav");
InventoryHideTime = cl.time+INVENTORY_DISPLAY_TIME;

}

[Ozkan Sezer]

This has been forgotten for some time and I will need to test
it before applying to the source tree. However I have already
made a new release a few days ago, and it will take some time
before I get back to things again.

Thanks for providing the patch.

[Jonathan Bergeron]

Cool! Let me know if you have any questions.

On Jun 12, 2018, at 1:43 PM, Ozkan Sezer sezero@users.sourceforge.net<mailto:sezero@users.sourceforge.net> wrote:

This has been forgotten for some time and I will need to test
it before applying to the source tree. However I have already
made a new release a few days ago, and it will take some time
before I get back to things again.

Thanks for providing the patch.

---

[bugs:#58]https://sourceforge.net/p/uhexen2/bugs/58/ Items dropping issues

Status: open
Group: 1.5.x
Created: Tue Apr 05, 2016 08:29 AM UTC by MilkeyWilkey
Last Updated: Sat Nov 18, 2017 08:05 PM UTC
Owner: nobody

1) If you select an item in the inventory, you cannot drop it until the inventory screen disappears. Until it happens you will drop previously selected item. since there is no way to speed up the process, the transfer of items to your frends in the coop can became very tedious process
2) dropped items produce loud barrel crack sound. that should not happen at all

---

Sent from sourceforge.nethttp://sourceforge.net because you indicated interest in https://sourceforge.net/p/uhexen2/bugs/58/

To unsubscribe from further messages, please visit https://sourceforge.net/auth/subscriptions/

[Jonathan Bergeron]

Sorry, wanted replied to the email thread not knowing it would show up here

[Ozkan Sezer]

Fixed in git as cof commit a2a2870fb:
https://sourceforge.net/p/uhexen2/uhexen2/ci/a2a2870fb439798904893196436e89d3c3ad2ffe/

Fix will be included in new 1.5.10 release, whenever that happens.
Closing as fixed.