Thread: RE: [UM1-coders] Warnings

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 422-6466

> From: J.P. King [mailto:jp...@he...]
> We now have no warnings under any of Solaris, Linux and FreeBSD.  :-)

Good grief!  How did you get rid of the const casts and the regexp stuff?

		- Peter

> From: J.P. King [mailto:jp...@he...]
> The const casts I dealt with by introducing a new variable 
> char *tmpstring
> and using strcpy to copy a const char * (or quoted string) into
> tmpstring, and then used that.

Ick!  Can you not fix the calls (that do not change their string) using
const_cast?

> > The const casts I dealt with by introducing a new variable 
> > char *tmpstring
> > and using strcpy to copy a const char * (or quoted string) into
> > tmpstring, and then used that.
> 
> Ick!
Yup.

> Can you not fix the calls (that do not change their string) using
> const_cast?

Probably - however that appears to be a C++ extension, and I don't
know any C++.  However I am reading what documentation I can
find to work out if we can use it, and how to use it if we can.

Julian

> From: J.P. King [mailto:jp...@he...]
> > Can you not fix the calls (that do not change their string) using
> > const_cast?
> 
> Probably - however that appears to be a C++ extension, and I don't
> know any C++.  However I am reading what documentation I can
> find to work out if we can use it, and how to use it if we can.

void f (char *s);
const char *cs;
f(s); // Should fail
f(const_cast<char *>(cs)); // Should succeed, I think

		- Peter

> void f (char *s);
> const char *cs;
> f(s); // Should fail
> f(const_cast<char *>(cs)); // Should succeed, I think

Tested, not really understood, but implemented cos it blatantly
works.  Changes committed.

> 		- Peter

Julian

> From: J.P. King [mailto:jp...@he...]
> Tested, not really understood, but implemented cos it blatantly
> works.  Changes committed.

It's a gross hack to trick the compiler into discarding a const without
giving a warning.  Nothing more, nothing less.  The fact that we have to use
it at all is worrying, but that's up to the library implementors.

		- Peter

> > We now have no warnings under any of Solaris, Linux and FreeBSD.  :-)
> Good grief!  How did you get rid of the const casts and the regexp stuff?

The regexp stuff wasn't done in the recent round of fixes - I am not 
even sure that it was me that dealt with that.

The const casts I dealt with by introducing a new variable 
char *tmpstring
and using strcpy to copy a const char * (or quoted string) into
tmpstring, and then used that.

It is undoubtedly inefficient, but it avoids having to fix
curses, which I view as a good thing.  :-)

> 		- Peter

Julian

Thread: RE: [UM1-coders] Warnings

uglycode-coders