uglycode-coders

[UM1-coders] Code changes

[J.P. K. <jp...@he...>]

Ok, fixed up the FreeBSD problems too - I think without exception they
were time related - the code was inconsistant about using time_t rather
than long.  Also, some OSes define time_t as a long int, and some as an
int.  This made the sprintf's interesting.  My chosen method of fudging
it was to cast the variables to a long int where used in a sprintf.

I believe that casting an int to a long is safe where it is only
being used in a sprintf?

Don't you love C?

I'll hit Solaris now, and see if that still compiles correctly.

Julian

Re: [UM1-coders] Code changes

[J.P. K. <jp...@he...>]

> I'll hit Solaris now, and see if that still compiles correctly.

Ok, apart from:

g++ -c -g -Wall -Wcast-qual -Wparentheses -Wwrite-strings -Wconversion interface
.c
In file included from /usr/include/curses.h:23,
                 from /usr/local/lib/gcc-lib/sparc-sun-solaris2.8/2.95.2/include
/curses.h:5,
                 from interface.c:48:
/usr/include/widec.h:38: warning: `getwc' redefined
/usr/include/iso/wchar_iso.h:337: warning: this is the location of the previous 
definition 
/usr/include/widec.h:39: warning: `putwc' redefined
/usr/include/iso/wchar_iso.h:340: warning: this is the location of the previous 
definition 
/usr/include/widec.h:40: warning: `getwchar' redefined
/usr/include/iso/wchar_iso.h:338: warning: this is the location of the previous definition
/usr/include/widec.h:41: warning: `putwchar' redefined
/usr/include/iso/wchar_iso.h:341: warning: this is the location of the previous definition
interface.c: In method `int descriptor_data::set_terminal_type(const char *)': 
interface.c:1870: warning: deprecated conversion from string constant to `char *'
interface.c:1877: warning: deprecated conversion from string constant to `char *'
interface.c:1900: warning: deprecated conversion from string constant to `char *'
interface.c:1908: warning: deprecated conversion from string constant to `char *'
interface.c:1916: warning: deprecated conversion from string constant to `char *'
interface.c:1924: warning: deprecated conversion from string constant to `char *'


and

g++ -c -g -Wall -Wcast-qual -Wparentheses -Wwrite-strings -Wconversion  variable.c
variable.c: In function `enum Command_status full_parse_expression(context &, const char *, char *, unsigned int)':
variable.c:1324: warning: comparison between signed and unsigned
variable.c:1364: warning: comparison between signed and unsigned
variable.c:1418: warning: comparison between signed and unsigned

 (which is a warning on all platforms)

Solaris compiled the code happily enough.  Anyone have any objections
if this code is committed?  (can I actually commit code?)  I can put
the code somewhere useful, or mail context diffs if people want?

Julian