From: Adrian S. J. <AS...@pa...> - 2001-12-12 09:40:54
|
> From: Peter Crowther [mailto:pet...@ne...] > > > From: Adrian St. John [mailto:AS...@pa...] > > When I get a chance, I'll run the source through lint here=20 > (I have one > > that deals with C++) >=20 > Cool! What is it, and is it generally available? It's Flex PC-Lint, and it is commercial. It is also available for UNIX (as source code!), but that would cost lots of money for a licence. >=20 > > > The rest of the changes are the creation of a tmpstring which is > > > used when calling tigetnum (and friends) which insist on a char * > > > and not a const char *. Again, I believe this is safe, but I > > > don't tend to mess with strcpy or malloc, so I am quite=20 > prepared to > > > believe that it is wrong. Also, whilst I know that it is the > > > terminal handling code, I am not sure how to test it. > >=20 > > Ah, that one. My personal preference would be to take the programmer > > who wrote those functions out to a wall and shoot them. >=20 > Do all the platforms we use have C++ compilers that can cope with > const_cast<char *>(str)? Given that all the platforms we use tend to be up to date, using g++, I suspect so. Adrian |