UFTP 5.0.2 client crash with tfmcc and no encryption

[Eriza Fazli]

Hi,

client crashes when using server options -Y none -C tfmcc. Both client and server are compiled with encryption. I tried swapping client and server (raspberry pi and laptop) with the same outcome. I was wondering if I might be missing something? Here below is a snippet:

server:
./uftp -R 600000 -B 20971520 -f -x 5 -Y none -C tfmcc:min=20000:init=600000 1GB.bin

client:
./uftpd -d -B 20971520 -c 20971520 -x 5

client output:

2023/11/28 18:48:02.809008: UFTP version 5.0.2 Copyright (C) 2001-2023 Dennis A. Bush
2023/11/28 18:48:02.810059: Loaded ECDSA key with curve prime256v1 and fingerprint D2:6F:78:B3:C9:69:98:EE:1C:77:D6:62:68:AC:61:0D:F4:4F:48:C2
2023/11/28 18:48:02.810100: read timeout: 1.000000
2023/11/28 18:48:03.811397: read timeout: 1.000000
2023/11/28 18:48:04.812455: read timeout: 1.000000
2023/11/28 18:48:05.813506: read timeout: 1.000000
2023/11/28 18:48:06.223009: tos / traffic class byte = 02
2023/11/28 18:48:06.225625: [A1930C8A/00:0]: Received request from C0A8B230 at blade.fritz.box (192.168.178.48)
2023/11/28 18:48:06.225658: [A1930C8A/00:0]: Using private multicast address 230.5.5.44
2023/11/28 18:48:06.225683: [A1930C8A/00:0]: grtt = 0.532216
2023/11/28 18:48:06.225881: [A1930C8A/00:0]: send time: 1701193686.184109
2023/11/28 18:48:06.225909: [A1930C8A/00:0]: receive time: 1701193686.223037
2023/11/28 18:48:06.226308: [A1930C8A/00:0]: REGISTER sent
2023/11/28 18:48:06.226338: [A1930C8A/00:0]: send time: 1701193686.187331
2023/11/28 18:48:06.226362: [A1930C8A/00:0]: found min timeout time: 1701193688:887439
2023/11/28 18:48:06.226624: read timeout: 1.000000
2023/11/28 18:48:07.227664: [A1930C8A/00:0]: found min timeout time: 1701193688:887439
2023/11/28 18:48:07.227699: read timeout: 1.000000
2023/11/28 18:48:07.726339: tos / traffic class byte = 02
2023/11/28 18:48:07.726368: [A1930C8A/00:0]: Got seq 1, max was 0
2023/11/28 18:48:07.726393: [A1930C8A/00:0]: current cc len = 1
2023/11/28 18:48:07.726580: [A1930C8A/00:0]: seq_wrap=0, max_txseq=1, start_seq=0
2023/11/28 18:48:07.726609: [A1930C8A/00:0]: grtt: 0.011
2023/11/28 18:48:07.726788: [A1930C8A/00:0]: Registration confirmed
2023/11/28 18:48:07.726817: [A1930C8A/00:0]: found min timeout time: 1701193688:726816
2023/11/28 18:48:07.726997: read timeout: 0.999999
2023/11/28 18:48:07.734967: tos / traffic class byte = 02
...
...
2023/11/28 18:48:08.323926: [A1930C8A/00:0001]: Got seq 23, max was 22
2023/11/28 18:48:08.323949: [A1930C8A/00:0001]: current cc len = 23
2023/11/28 18:48:08.323971: [A1930C8A/00:0001]: seq_wrap=0, max_txseq=23, start_seq=0
2023/11/28 18:48:08.323994: [A1930C8A/00:0001]: grtt: 0.011
2023/11/28 18:48:08.324019: [A1930C8A/00:0001]: ccrate=66496
2023/11/28 18:48:08.324053: [A1930C8A/00:0001]: CC_ACK sent
double free or corruption (top)
Aborted

[Dennis Bush]

Yes, this was a bug introduced in the most recent version. There was an update to fix a memory leak, but the fix wasn't applied correctly. I'll send out an updated release soon.

[Eriza Fazli]

Thanks Dennis!