Thanks for your effort. I have added your patch with a small change: HAVE_GIMP_2_9 is always defined so the code must check for the value (as a boolean type). Please test that it work as expected. I have tested it on a system with GIMP 2.8.4 and Cinepaint, but not with GIMP 2.9.x.
Regards,
Niels Kristian
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Ahh thanks for spotting and fixing that. I've built from the change you committed and everything works as expected for me:
- 8 and 16 bit output depth are offered in the color mgmt tab
- developing a raw file with 16 bits of depth actually gives you more precision (checked by diff'ing 8 and 16 bit developed image in gimp, then stretching contrast)
There's some other stuff I have in a private git branch (use non-deprecated gimp functions), or which I could work on (e.g. janitorial stuff like warnings, let users specify other GIMP-native precision besides 8/16bit integer). Should I contact Udi to get CVS access for that?
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I've worked on a patch which I've posted for review to the development mailinglist:
https://sourceforge.net/mailarchive/forum.php?thread_name=1361279527.28476.6.camel%40gibraltar.str.redhat.com&forum_name=ufraw-devel
https://sourceforge.net/mailarchive/attachment.php?list_name=ufraw-devel&message_id=1361279527.28476.6.camel%40gibraltar.str.redhat.com&counter=1
Hi Nils.
Thanks for your effort. I have added your patch with a small change: HAVE_GIMP_2_9 is always defined so the code must check for the value (as a boolean type). Please test that it work as expected. I have tested it on a system with GIMP 2.8.4 and Cinepaint, but not with GIMP 2.9.x.
Regards,
Niels Kristian
Ahh thanks for spotting and fixing that. I've built from the change you committed and everything works as expected for me:
- 8 and 16 bit output depth are offered in the color mgmt tab
- developing a raw file with 16 bits of depth actually gives you more precision (checked by diff'ing 8 and 16 bit developed image in gimp, then stretching contrast)
There's some other stuff I have in a private git branch (use non-deprecated gimp functions), or which I could work on (e.g. janitorial stuff like warnings, let users specify other GIMP-native precision besides 8/16bit integer). Should I contact Udi to get CVS access for that?
Hi Nils.
Yes, you must get in touch with Udi for cvs write access.
Regards,
Niels Kristian