Menu
▾
▴
5 Attachments
#371 Lensfun distortion correction affects crop area even if "autofit" deselected
Steps to reproduce:
- Open raw file with UFRaw 0.19.2-2. This raw file needs to be shot with a lens that lensfun recognizes.
- Make sure that Crop and rotate/Auto fit crop area cogwheels are not activated.
- Klick the Crop and rotate/Reset the crop area button to make sure, that no crop area has been manually selected.
- Play with the Lens correction/Lens distortion/b parameter (PanoTools lens model).
- Result: A crop frame appears, even if Crop and rotate/Auto fit crop area was not activated. Crop frame does not seem to be correlated to any image contents.
- This effect does not happen, when a crop area has been manually selected before. The Auto fit crop area option seems to work fine.
See attached screenshots for details.
Discussion: If no crop area has been initially selected, I expect the coordinates to stay on their values after applying Lensfun corrections and no crop frame to appear.
Cropping has no off state, it's always on, UFRaw cannot distinguish between manually entered margins and numbers that were filled in automatically when the image was opened ofcourse this could be fixed, a member named cropOn or fullCrop could be added to conf_data, its default state should be true and the reset button should set it to true, any other button or entry should set it to false.
resize_canvas() in ufraw_preview.c should then be made to handle this new option and apropriate modifications should be made elsewhere too. Do Udi or Niels want me to do this? Udi already claimed the bug.
Hi Frank.
Please implement your ideas. We will look at your patch when you submit it.
Thank you for all the work you have done on UFRaw.
Regards,
Niels Kristian
Here is the fix, I hope the diff won't give to many problems, I edited it by hand because the CVS repo and my code are a bit out of sync.
Thank you for the fix. I have commited it to the cvs repository.
Regards,
Niels Kristian