#342 ufraw-0.19.2 doesn't support building on ARM 64bit

closed-fixed
nobody
None
5
2013-03-27
2013-03-26
No

ufraw-0.19.2 comes with config.{guess,sub} which don't know the ARM 64bit architecture (aarch64) even though version 0.19 comes with versions of these files that do. Apparently, for the 0.19.2 tarball these files were generated with an old automake version before 1.12 (which adds the new architecture) and for 0.19 a current version was used (for automake --add-missing --force-missing --copy, or autoreconf --force --install, respectively).

While this version of automake could be enforced as minimum (AM_INIT_AUTOMAKE([foreign 1.12]) in configure.ac) I don't think that's desirable because it could prevent people from building with older versions of automake even on supported architectures. An alternative could be to grep for the string aarch64 in both config.guess and config.sub from the dist-local or distcheck-local targets (depending on what is used for generating the tarballs) and erroring out if it's not present.

Discussion

  • Udi Fuchs
    Udi Fuchs
    2013-03-26

    I'm using Ubuntu 12.10, which has authomake 1.11.6. I wonder where the automake 1.12 files for ufraw 0.19 came from.

     
  • I think Ubuntu backported some parts of automake. This is from Ubuntu 12.04:

    nkbj@bohrium:~/ufraw$ cat /etc/motd
    Welcome to Ubuntu 12.04.2 LTS (GNU/Linux 3.2.0-39-generic x86_64)

    nkbj@bohrium:~/ufraw$ automake --version
    automake (GNU automake) 1.11.3
    Copyright (C) 2011 Free Software Foundation, Inc.
    License GPLv2+: GNU GPL version 2 or later http://gnu.org/licenses/gpl-2.0.html
    This is free software: you are free to change and redistribute it.
    There is NO WARRANTY, to the extent permitted by law.

    Written by Tom Tromey tromey@redhat.com
    and Alexandre Duret-Lutz adl@gnu.org.
    nkbj@bohrium:~/ufraw$ grep -i aarch64 config
    config.guess: aarch64:Linux:
    :)
    config.guess: aarch64_be:Linux:
    :)
    config.guess: UNAME_MACHINE=aarch64_be
    config.sub: | aarch64 | aarch64_be \ config.sub: | aarch64-
    | aarch64_be-* \ nkbj@bohrium:~/ufraw$

    Regards,
    Niels Kristian

     
  • The config.{guess,sub} files in UFRaw 0.19 are dated Dec 5 2012, while the files in 0.19.1 and 0.19.2 are identical to the files in 0.18 (dated Feb 14 2010). Seems some old files were copied into the 0.19.[12] release directory.

    Regards,
    Niels Kristian

     
    • status: open --> closed-fixed
     
  • I have just uploaded a new ufraw-0.19.2.tar.gz with the generated files from ufraw-0.19.tar.gz.

    Regards,
    Niels Kristian