From: <Sve...@nt...> - 2005-07-03 13:05:25
|
Author: SvenDowideit Date: 2005-07-03 06:04:43 -0700 (Sun, 03 Jul 2005) New Revision: 4505 Modified: twiki/branches/DEVELOP/bin/configure Log: Item44: removed perl warnings about concatination of undefined string, by checking that there was a return to the version call - and erroring if there wasn't Modified: twiki/branches/DEVELOP/bin/configure =================================================================== --- twiki/branches/DEVELOP/bin/configure 2005-07-03 12:47:07 UTC (rev 4504) +++ twiki/branches/DEVELOP/bin/configure 2005-07-03 13:04:43 UTC (rev 4505) @@ -596,11 +596,15 @@ if ( $key && $key =~ /Cmd$/ ) { my $proggy = $TWiki::cfg{RCS}{$key} || ""; $proggy =~ s/\s.*$//; - if( $proggy) { + if( $proggy ) { my $version = `$proggy -V` || ''; - $version =~ /(\d+(\.\d+)+)/; - $version = $1; - $proggy .= " (version $version)"; + if ( $version ne '' ) { + $version =~ /(\d+(\.\d+)+)/; + $version = $1; + $proggy .= " (version $version)"; + } else { + $bad .= ERROR($proggy.' did not return a version number. (or might not exist..)'); + } if( defined( $cygwinRcsVerNum )) { $proggy .= " (Cygwin package <tt>rcs-$cygwinRcsVerNum</tt>)"; } |