Re: See my mod (upgrade)

[Eddie <one...@te...>]

> Hmmm .... is quite hard to process things like it:

> 1) You should send a diff and not a replacement.
> 2) You are breaking the original indentation.
> 3) That's incomplete, you are using ASCII 0xF without hooking to the code
> page stuff. It means your icon looks like a random char on other 
> platforms.
> 4) You are not providing a way to enable/diable it.
> 5) You are using static_cast, I don't know if all the compiler we support
> have this feature. Additionally it needs extra info not always generated 
> (on purpose to reduce binary size).
> 6) You are using bool (not used in other place of the lib).
> 7) The character you used (sun/star) isn't available in all consoles and 
> is reduced to the same ASCII than the black square. Both are reduced to *.

> I'll incorporate it but with some changes and will see the result.

Ad. 1. I will try, but give me an advise, how to do it or give me diff-file
format description. Sorry bothering, but I never wrote diff-file.

Ad. 2. Yes I know but it's strange I search a little before I wrote the code
to check if it's already written. Nothing found. I check DosNavigator pascal
sources and there also nothing found. I searched for tv.2 pascal sources
but, not found. So I run BP7 ide and wrote the code being careful on this to
code acted identically as I saw it in ide.
I think it should be added by tv authors. I do not know why do they skip
this part of code.

Ad.3, 5, 6, 7. Sorry I wasn't thinking about (platforms) porting stuff. I
wrote it to use it in VC.

> The CVS snapshot contains it.

Nice. Thanks.