#300 Mirror/Flip not working for Starters & Templates

[William Kendrick]

Starters

To reproduce:

• New
• Select a Starter (e.g., the movie film frame)
• Choose the Magic -> Flip tool & use it

Expected Behavior:

• The Starter flips along with anything else in the drawing (e.g. from "< <" to "> >")

Actual Behavior (Bug):

• The copy of the Starter applied to the canvas is flipped, but the origianl Starter is re-applied (e.g. from "< <" to "X X")

h/t 'Wisdom Lupus' for reporting. They mention that Templates are not affected, however I believe they ALSO are not working correctly; see below:

Templates

To reproduce:

• New
• Select a Template (e.g., the lighthouse)
• Choose the Magic -> Flip tool & use it
• Choose the Eraser tool and erase part of the picture

Expected Behavior:

• Nothing should change (if anything had been drawn over the template, the original background, now flipped, should reappear) (e.g., from "O-X", flipped to "X-O", and remaining that way when erased)

Actual Behavior (Bug):

• The Template flips along with anything else in the drawing. When using Eraser, the flipped version of the Template should be exposed, not the original. (e.g., from "O-X"; flipped to "X-O", but when erased you could end up with "O-O" or "X-X", for example)

[Rieley Hunt]

Hi there!

Has anyone taken a further look at this? I've been curious to try and make a patch for it :)

[Pere Pujal i Carabantes]

Hi, and welcome :)

This is an old problem that has been around for years.
See
https://sourceforge.net/p/tuxpaint/bugs/103/
which was replaced by
https://sourceforge.net/p/tuxpaint/feature-requests/124/
and the current one.

That said, I imagine one can modify the magic API in order to pass the foreground and background surfaces to the magic tools (or a way for them to access these surfaces), then modify the needed magic tools to apply their effect to the three surfaces, canvas, img_starter (foreground surface)and img_starter_bkgd (background surface)

I wonder if additional "last" surfaces would be needed for foreground and background ones?

HTH
Pere