Menu

#237 src/tuxpaint.c:3311: duplicate condition ?

v0.9.25
closed
nobody
None
1
2021-10-21
2021-10-20
dcb
No

gcc compiler can be made to say:

src/tuxpaint.c:3311:45: warning: duplicated 'if' condition [-Wduplicated-cond]
3311 | else if (cur_tool == TOOL_FILL)
| ~~~~~~~~~^~~~~~~~~~~~
src/tuxpaint.c:3169:45: note: previously used here
3169 | else if (cur_tool == TOOL_FILL)
| ~~~~~~~~~^~~~~~~~~~~~

It looks like one of the if conditions should be deleted.

Discussion

  • William Kendrick

    • status: open --> closed
     
  • William Kendrick

    Mended, thanks! (https://sourceforge.net/p/tuxpaint/tuxpaint/ci/ccb061144a19636333d7266f6c41896609368f43/)

     

Log in to post a comment.