I took configure.in and:
- Applied the Xlib warning fix.
- Renamed it configure.ac (this forces the use of newer autoconfs).
- Removed acconfig.h (running autoconf will tell you to do this).
- Made sure all AC_DEFINE calls had 3 parameters.
- Ran autoscan, and added new checks based on what it said.
- Merge AC_SUBST calls.
This isn't going to make any big difference, but the removal of
acconfig.h is generally helpful.
There is a lot of cruft in there that I would never have put there, but
the original authors probably wouldn't want removed.
For instance:
if test "x$enable_warnings" = "xyes"; then
CFLAGS="$CFLAGS -pipe -W -Wall -ansi -pedantic -Wbad-function-cast \
-Wcast-align -Wcast-qual -Wchar-subscripts -Winline \
-Wmissing-prototypes -Wnested-externs -Wpointer-arith \
-Wredundant-decls -Wshadow -Wstrict-prototypes -Wwrite-strings"
else
CFLAGS="$CFLAGS -pipe -Wall"
fi
is generally not too helpful, since only the developers will want it and
you can get the same effect just by adding a CFLAGS to make. It is also
likely to break under non-gcc compilers.
Then we have:
dnl--------------------------------------------------------------------
dnl Don't assume we want high level optimisations, it is known to
dnl produce broken code on certain architectures using certain compilers
dnl --------------------------------------------------------------------
CFLAGS="-O -g"
which again seems gcc-centric and is probably wrong (I'm told that every
"common" compiler bug in optimized code is actually a bug in the code
being compiled).
jason
|
