[Tuxnes-devel] Re: tuxnes patch

[Mike M. <che...@ya...>]

I have reviewed and committed this.  Here are my comments.

--- Rigel Freden <ri...@po...> wrote:
> I found the x86 core was broken due to next_code_alloc in function
> translate being erroneously assigned to a constant value.  Attached is
> a diff -Nru of my changes, all minor:
>  - removal of preproc symbol REG1 in common code; REG1 is now only 
>    used in x86 core code
It may get used in ppc and/or sparc asm targets.  Aside from a slightly
longer build I don't see why I'd remove it.

>  - defines.h now contains (only?) defines for the x86 core; this
>    in turn makes nasty preproc code emulator_x86_asm.S unnecessary
This is x86/tuxnes specific, it can be moved too emulator_x86_asm.h or the
like.  defines.h is just not the place for this, if changed I don't have
any problems committing this.

>  - added a dirty hack in unzip.h because for some reason my system
>    seems to fail to define ZEXPORT
Jason currently knows more about autoconf than I do.

>  - fixed memory allocation/deallocation in InitMemoryX86 and
>    FreeMemoryX86; specifically fixed issue w/ ROM mem persisting
Good catch, is there any reason MapperInit_X86 needs to be compiled in? 
At this time Mapper_X86 is compiled in for linking with
emulator_x86_asm.S, I'm not skilled enuff to (re)move it.

>  - removed weird-ass embedded open comments in emulator_x86_asm.S
> e.g.
>    "/* /* */ "
I did this, I committed a cleaner fix.

> 
> there are still many issues.. on my system i get mad screen flicker,
> it's slooow, etc.
> 
Really, what type of system do you have?

> --
> 
> Mike Mestnik wrote:
> 
> > Are you kiding...
> > I'd love to know why x86 dosen't draw anything.  Also on the do not
> crash
> > or draw list is GGI.
> > 
> > I'm posting to "sourceforge.net tuxnes-devel"
> > <tux...@li...>, hopefully Jason is still around.
> > 
> > --- Rigel Freden <ri...@us...> wrote:
> > > i have a patch that fixes the broken x86 core in cvs while breaking
> > > nothing 
> > > 
> > > new.  if you could use it please email me: ri...@po...
> 

> ATTACHMENT part 2 application/bzip2 name=tuxnes.diff.bz2


	
		
__________________________________
Do you Yahoo!?
Win a $20,000 Career Makeover at Yahoo! HotJobs  
http://hotjobs.sweepstakes.yahoo.com/careermakeover