tuxmath-devel

[Tuxmath-devel] Small bugs

[Tim H. <ho...@wu...>]

Hi,

I finally got back to looking at tuxmath, and there have been a lot of good 
changes!

Two small bugs:
1. In options.c, the function Opts_SetMaxComets actually sets 
game_options->extra_comets_per_wave rather than game_options->max_comets. 
This causes there to be 2 comets in the first wave, but 10 comets in the 2nd 
(rather than the 4 that was intended), and the options file written in the 
user's .tuxmath directory does not live up to the stated defaults.

2. (documentation bug) In the README.txt in the doc/ directory, the section 
about "Setting Administrative Options" claims the system-wide options file is 
in /usr/local/share/tuxmath/, but on my installation it's in the "missions" 
subdirectory of this directory.

--Tim

[Tuxmath-devel] Small bugs

[Tim H. <ho...@wu...>]

Hi,

I finally got back to looking at tuxmath, and there have been a lot of good 
changes!

Two small bugs:
1. In options.c, the function Opts_SetMaxComets actually sets 
game_options->extra_comets_per_wave rather than game_options->max_comets. 
This causes there to be 2 comets in the first wave, but 10 comets in the 2nd 
(rather than the 4 that was intended), and the options file written in the 
user's .tuxmath directory does not live up to the stated defaults.

2. (documentation bug) In the README.txt in the doc/ directory, the section 
about "Setting Administrative Options" claims the system-wide options file is 
in /usr/local/share/tuxmath/, but on my installation it's in the "missions" 
subdirectory of this directory.

--Tim

Re: [Tuxmath-devel] Small bugs

[David B. <db...@ta...>]

Hi Tim,

On Thursday 16 November 2006 22:22, Tim Holy wrote:
> Hi,
>
> I finally got back to looking at tuxmath, and there have been a lot of good
> changes!
>
> Two small bugs:
> 1. In options.c, the function Opts_SetMaxComets actually sets
> game_options->extra_comets_per_wave rather than game_options->max_comets.

> 2. (documentation bug) In the README.txt in the doc/ directory, the section
> about "Setting Administrative Options" claims the system-wide options file
> is in /usr/local/share/tuxmath/, but on my installation it's in the
> "missions" subdirectory of this directory.

Thanks for the pickups - fixed and committed.

Cheers,
-- 
David Bruce

Re: [Tuxmath-devel] Small bugs

[Holger L. <de...@la...>]

Hi,

On Friday 17 November 2006 12:13, David Bruce wrote:
> Thanks for the pickups - fixed and committed.

should this be 1.0.1 and uploaded to debian to hopefully make it into etch?


regards,
	Holger

Re: [Tuxmath-devel] Small bugs

[David B. <db...@ta...>]

Hi Holger,

On Friday 17 November 2006 17:10, Holger Levsen wrote:
> should this be 1.0.1 and uploaded to debian to hopefully make it into etch?

If Debian is still taking uploads for etch, fine with me!  I fixed Tim's bug 
and another similar one I found - no significant changes to the code that 
might introduce new bugs.

On other fronts (i.e. tuxtype and the planned menu overhaul), the crossbuild 
support for tuxtype works fine - tested with a clean checkout in a separate 
directory.  I've been studying the tuxtype menu code (with a little clean-up 
and commenting as I go) to get ready to use it in tuxmath.

Cheers,
-- 
David Bruce

Re: [Tuxmath-devel] Small bugs

[Holger L. <de...@la...>]

Hi,

On Saturday 18 November 2006 12:56, David Bruce wrote:
> If Debian is still taking uploads for etch, fine with me!=20

Well, it's not completly clear when the freeze starts at the moment... and=
=20
uploads to unstable are certainly still possible.

> I fixed Tim's=20
> bug and another similar one I found - no significant changes to the code
> that might introduce new bugs.

Uploaded now.

> On other fronts (i.e. tuxtype and the planned menu overhaul), the
> crossbuild support for tuxtype works fine - tested with a clean checkout =
in
> a separate directory.  I've been studying the tuxtype menu code (with a
> little clean-up and commenting as I go) to get ready to use it in tuxmath.

Yay! Have fun & enjoy! :)


regards,
	Holger