From: Brendan L. <bm...@ri...> - 2010-08-06 19:39:28
|
Hi Tim, On Fri, Aug 6, 2010 at 6:29 AM, Tim Holy <ho...@wu...> wrote: > On Thursday, August 05, 2010 09:32:18 pm you wrote: > > I look forward to testing the improvements! > > > > Why wait :)? Take a look now, and tell me if there are any gaping holes > to > > plug up before focusing on documentation and--well--testing. But yes, > time > > sure has flown. I should be tying up all the major stuff by tomorrow. I > > hope. > > Good point! It seems I've been waiting to check master---I'm still clunky > on > git, I guess, and don't always notice updates in other branches (how the > heck > do you know that there are things waiting to be pulled?). But I just > switched > to commonification, and it plays well! At the user level, one way I noticed > that it's improved over master is that on the "campaign" modes it doesn't > dump > a whole lot of text to the console. I did notice a bit: > > Entering start_campaign() > Stage cadet > Round 1 > Starting game... > > and that could presumably be put under our "debug" infrastructure, but it's > much, much less than master currently dumps. And I did not notice any > disadvantages to commonification. > What a pleasant surprise! There was one disadvantage, and a big one: sprite caching wasn't working properly due to the dimensions being read incorrectly. But I think I've nailed that one. Much earlier than I expected, too. At this point, I'm ready to call it stable, if there aren't any more subtle bugs hiding, and move on to tidying things up as per SoC guidelines. The campaign could definitely use an update or two. I don't think it's been touched for over a year (certainly not since Bolek put in the sweet debugging system), barring the quick fix a couple of weeks ago. I'll make a note to give it some TLC. Best, Brendan |