Re: [Tuxmath-devel] Migration chugging along nicely

[Brendan L. <che...@gm...>]

Hey Wenyuan,

Thanks for taking a look!



> 1. t4k_menu.c: when user press F10, you need to resize both the title
> screen and menu items. Currently "T4K_PrerenderAll" doesn't seem to
> resize title screen. You probably need to hook up with the appropriate
> function in "titlescreen.c" (or your equivalent in t4kcommon).
>

Right, I think we want to keep a separation between the titlescreen
(generally, game-specific stuff) and the actual menu. So it's taken care of
in HandleTitleScreenResSwitch() in titlescreen.c. This function is called
directly by HandleTitleScreenEvents() but should probably be a separate
callback passed to T4K_RunMenu().

I should have pushed all the changes necessary for this (at least) to work
right. Does it still look funky on your end?


> 2. t4k_loaders.c: you don't seem to have SVG sprites prerender code
> yet. Just for your reference, this feature is implemented in
> "load_sprite" function of "loaders.c" in tuxmath. Migrating it ought
> not to be an issue.
>

Ah, good catch. Sweet!

 I did notice, while looking through get_svg_dimensions(), that it calls
rsvg_init() and rsvg_term(). I'm not familiar with RSVG but I'd expect those
to be meant to be called once per run. Do you think that might be the reason
for the bottleneck in getting SVG dimensions?

Best,
Brendan