Re: [Tuxmath-devel] Patch: Cleaner exit on error

[David Y. <hob...@gm...>]

Holger,

I couldn't find a working tuxtype list, so I'll just post here.

The fix I made to tuxmath is already present (perhaps in a more elegant way)
in tuxtype. That is, calling SDL_Quit for all exits. In tuxtype it is done
with atexit(). The bug report stated it was found in 1.0-4. I looked all the
way back to CVS Tag 0.9 on the sourceforge CVS repository, and the same
atexit(SDL_Quit) method is used everywhere I look.

The version I installed with Ubuntu Dapper, 1.0, is working correctly
(switches to a different resolution fullscreen, then switches back at exit).


Just to be sure I got the latest source of tuxtype2 from
https://svn.tux4kids.net/tuxtype/ and compiled. It exited normally with
<esc> and quit menu and by moving the images directory to cause an error
exit.

Being Dapper, my DSL libraries are newer than reported in the bug. And I
don't have a clue what other than the X server is in the chain to change X
resolution. So I'm not reproducing the exact case. But at least the problem
doesn't seem to be in tuxtype.

In summary I couldn't reproduce the bug. I don't know what Debian's policies
are on closing bugs that can't be reproduced (and are 3 years old).

David

On 8/19/06, Holger Levsen <de...@la...> wrote:
>
> Hi David,
>
> On Saturday 19 August 2006 07:56, David Yoder wrote:
> > I noticed that if I am running fullscreen and exit due to a failure to
> load
> > images, the screen resolution stays at 640x480. It's easy enough to
> change
> > it back, but annoying.
> >
> > So, I modified the exit on errors to cleanup a bit better. Now error
> exits
> > in setup.c call SDL_Quit and the other heap cleanup that was already
> > present on a normal exit. Except the first error exit because no heap
> space
> > allocation or SDL calls have been made at that point.
> >
> > I made the assumption that if exiting due to an error, you wouldn't want
> to
> > save the options to the configuration file.
>
> Great! Thanks a lot!
>
> Do you think you could "port" this patch to tuxtype as well? It has the
> same
> problem, see http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=217448
>
>
> regards,
>         Holger
>
>
> -------------------------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job
> easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
>
> _______________________________________________
> Tuxmath-devel mailing list
> Tux...@li...
> https://lists.sourceforge.net/lists/listinfo/tuxmath-devel
>
>
>
>