Re: [TuxKart-devel] Re: [Tuxkart-cvs] tuxkart/src Driver.h,1.14,1.15 joystick.h,1.3,1.4 PlayerDrive
Status: Alpha
Brought to you by:
sjbaker
From: Steve B. <sjb...@ai...> - 2004-08-07 18:12:24
|
James Gregory wrote: > On Sat, 2004-08-07 at 08:22, Ryan Flegel wrote: > >>On Sat, 07 Aug 2004 03:38:41 +0000, >>tux...@li... >><tux...@li...> wrote: >> >>>Update of /cvsroot/tuxkart/tuxkart/src >>>In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv7377/src >>> >>>Modified Files: >>> Driver.h joystick.h PlayerDriver.cxx sdldrv.cxx sdldrv.h >>>Log Message: >>>- Changed PLIB joystick stuff to SDL joystick stuff...Steve won't be happy >> >>Is this necessary? If you're moving something away from PLIB their >>should be good reasons, like there was for the GUI. I can't really see >>why there would be any problems with PLIB for input. > > > 1. The GUI was already using SDL for joystick input, as it is event > based (which PLIB doesn't do). Therefore it was already using SDL for > some joystick input, and using two different joystick libraries at the > same time seemed silly. > > 2. All the other input is already handled by SDL, so changing the > joystick to SDL unifies the input code somewhat. > > 3. Changing the joystick input to SDL doesn't add any more dependencies > as the joystick stuff is in the plain base SDL library > > 4. I wanted to add support for multiple joysticks, and though this is > admittedly possible with PLIB, it is easier with SDL. > > 5. The PLIB joystick code relies on you testing for hexadecimal codes, > which isn't very programmer-friendly. The joystick code in the game is > now much more readable. As I have said before...I WILL NOT MAINTAIN SDL code. When you guys eventually leave this project, I'm going to have to rip out all this SDL stuff...so unless you want to fork the code base (and remember you'll be maintaining the game *forever* if you do) - then please don't put SDL stuff in there. It's completely unnecessary to do this switch - and it's a total waste of effort - both for you to put it in and for me to take it out again. The idea of GOTM is to help a project - not to make a complete pig's breakfast of it. ---------------------------- Steve Baker ------------------------- HomeEmail: <sjb...@ai...> WorkEmail: <sj...@li...> HomePage : http://www.sjbaker.org Projects : http://plib.sf.net http://tuxaqfh.sf.net http://tuxkart.sf.net http://prettypoly.sf.net -----BEGIN GEEK CODE BLOCK----- GCS d-- s:+ a+ C++++$ UL+++$ P--- L++++$ E--- W+++ N o+ K? w--- !O M- V-- PS++ PE- Y-- PGP-- t+ 5 X R+++ tv b++ DI++ D G+ e++ h--(-) r+++ y++++ -----END GEEK CODE BLOCK----- |