Re: [tuxdroid-user] Tux Droid and Pidgin!!

[<ror...@gm...>]

"Julien Ruchaud" <jul...@gm...> writes:

> Hi,
> I post on the forum a new version, now Tuxdroid speaks with TTS voices
> that say the contact on pidgin. I can't really test because I haven't
> got tuxdroid, so I need somebody test and say if it run.

Hello,

Just tried it and I have a few comments:

1. There is a bunch of ^M at the end of the lines in the module's doc
   string and in __author__, __app__name, etc. Please don't use these
   in the Unix/Linux world. (See dos2unix.)

   There is trailing whitespace. It's ugly and may lead to conflicts
   or unnecessary diffs when merging/committing in svn. Your editor
   probably has an option to remove these automatically.

2. I think you should use underscores in your function names:
   received_im_msg() and buddy_signed_on() are much more readable than
   receivedimmsg() and buddysignedon().

3. When pidgin is not running, your script dumps an exception; it
   should catch it and print a nice, user-friendly error message
   instead.

4. When I started pidgin and then your script, the latter printed on
   stdout that "Blah is online" (which was right) but Tux didn't *say*
   it. Both tuxdaemon and tuxttsdaemon where running.

I'll keep your script running and see what happens when my contacts
come and go.

	Damien