Re: Getting closer to tumanako FOC

[Robin V. <cz...@su...>]

hey... sorry for the long delay!
have there been any advances on your side?
i now had a look at it again, and have some more questions:

- why are foc.h and foc.cpp in lib. are they also used by sine?
- do you actually use the Makefile in lib/ ? (it seems to come from the
libopenstm32 project)
- in the src/ folder of the repo tuamanako-inverter-fw-motorControl,
there are other sources (partly in sub-folder), other then sine/. what
are these used for? are they actually separate projects?

with my current, very limited view of it, i think of this ways to solve
the issue:
putting lib/ into a separate project called something like
motorControl-common, and compiling it into a static lib, is the most..
natural way of doign it. it can be compiled separately for each
motorControl implementation, using different #define's.
most likely, we would then use the common repo as a git sub-module in
the sine/ and foc/ repos.
what about the other sources currently in the repo, but not in hte sine/
folder?

On 02.04.2013 20:01, Johannes Hübner wrote:
> Am 01.04.2013 23:19, schrieb Robin Vobruba:
>> i can do that, but i think i need some more info.
>>
>> the archive contains the lib and the foc folder, but not the sine one.
>> where is the latest version of that one?
> The sine project is already in the git repo and contains all the files 
> in lib. So if it somehow uses the files in lib, they can be deleted from 
> the sine project.
> https://github.com/tumanako/tumanako-inverter-fw-motorControl/tree/master/src/sine
> 
>>
>> what do you mean with 'more meaningful renaming'? the folders? (foc &
>> lib), or the source file names?
>> i guess, you mean the lib folder. but i also think, you would be best to
>> choose a more meaningful name.
> Yeah, just the lib folder. Still can't think of anything more meaningful 
> yet since the contents is very "miscellanious".
>>
>> do both sine and foc use all the files from lib?
> Almost, about 90% share ratio
>>
>> could it make sense to actually make the stuff in lib a separate
>> library, static of dynamic, against which the other two projects link?
>>
>>
> Some files, like the params.c, contain static tables that are build from 
> a project-dependend #define. The macro-magic for this is hidden in the 
> module.  All others could indeed be built as a static library. I can 
> create a list of actually static files if you want.
> 
> ------------------------------------------------------------------------------
> Minimize network downtime and maximize team effectiveness.
> Reduce network management and security costs.Learn how to hire 
> the most talented Cisco Certified professionals. Visit the 
> Employer Resources Portal
> http://www.cisco.com/web/learning/employer_resources/index.html
> _______________________________________________
> Tumanako-devel mailing list
> Tum...@li...
> https://lists.sourceforge.net/lists/listinfo/tumanako-devel
>