#14 tsclient printer redirection patch

open
nobody
None
5
2009-05-23
2009-05-23
No

I have prepared a patch for printer redirection support. I copied the code from the drive redirection patch. It is against 0.150. It searches for all printers and adds each one automatically.

I do have a concern about buffer overrun due to existing use of sprintf(buffer, ...) if someone deliberately puts too many printers on their system or printers with very long names. I'm not a professional programmer so it would be nice if someone could enlighten me as to why sprintf(buffer,...) is used instead of a GString?

Discussion

  • Joseph Miller

    Joseph Miller - 2009-05-23

    printer redirection against 0.150

     
  • Nobody/Anonymous

    Where i must copy the patch?

     
  • Joseph Miller

    Joseph Miller - 2009-06-04

    To use this patch, download tsclient 0.150 then run the commands:

    cd tsclient-0.150/
    patch -Np1 < printer_patch.patch
    autoconf
    ./configure && make

     
  • Nobody/Anonymous

    Patch commited. Thanks.

     
  • Nobody/Anonymous

    As to your comment about sprintf, it's quite valid, it should be replaced.

     

Log in to post a comment.