From: Rick M. <k1...@ar...> - 2020-10-31 19:06:41
|
I've published a release candidate for TQSL 2.5.6 - details below. Defects Corrected: 1. In cases where applications pass empty passwords on the command line (-p ""), TQSL could ignore that password and handle the command incorrectly. This was not the behavior prior to TQSL 2.5.5. 2. Ask the user to save a log being edited in the ADIF editor when they close the editor window. Previously, TQSL would discard the file. 3. TQSL more accurately prints the line number of an ADIF file with an error message. In the past, TQSL always reported the line containing the end-of-record tag. In addition, TQSL now uses the word "Passphrase" to distinguish between the password used for the LoTW site and the passphrase used to secure a Callsign Certificate. TQSL now also has a Swedish localization, thanks to SM0LTV. The other localizations have also been updated. A big change in the packaging for TQSL 2.5.6 for MacOS is the use of a signed and notarized (by Apple) package file ".pkg" for installing TQSL on a Mac. Having a signed installer increases the compatibility with current MacOS versions (Catalina and Big Sur). I'm very interested in feedback with these package files, as they're much easier to install. Download links below. Windows: https://www.rickmurphy.net/lotw/tqsl-2.5.6.msi Mac (64/32 bit, current systems) https://www.rickmurphy.net/lotw/tqsl-2.5.6.pkg (Installer) https://www.rickmurphy.net/lotw/tqsl-2.5.6.dmg (Disk image) Mac (Intel 386/Power PC legacy systems) https://www.rickmurphy.net/lotw/tqsl-legacy-2.5.6.pkg (Installer) https://www.rickmurphy.net/lotw/tqsl-legacy-2.5.6.dmg (Disk image) Linux/BSD: https://www.rickmurphy.net/lotw/tqsl-2.5.6.tar.gz (source code only) 73, -Rick -- Rick Murphy, CISSP-ISSAP, K1MU/4, Annandale VA USA |
From: Walter F. <dl...@da...> - 2020-11-01 00:49:33
|
Compilation for openSUSE 15.2 and Tumbleweed fails. The build logs with the error at the end are added to this mail. 73, Walter DL8FCL Am 31.10.20 um 19:06 schrieb Rick Murphy: > I've published a release candidate for TQSL 2.5.6 - details below. > > Defects Corrected: > 1. In cases where applications pass empty passwords on the command > line (-p ""), TQSL could ignore that password and handle the command > incorrectly. This was not the behavior prior to TQSL 2.5.5. > 2. Ask the user to save a log being edited in the ADIF editor when > they close the editor window. Previously, TQSL would discard the file. > 3. TQSL more accurately prints the line number of an ADIF file with an > error message. In the past, TQSL always reported the line containing > the end-of-record tag. > > In addition, TQSL now uses the word "Passphrase" to distinguish > between the password used for the LoTW site and the passphrase used to > secure a Callsign Certificate. > > TQSL now also has a Swedish localization, thanks to SM0LTV. The other > localizations have also been updated. > > A big change in the packaging for TQSL 2.5.6 for MacOS is the use of a > signed and notarized (by Apple) package file ".pkg" for installing > TQSL on a Mac. Having a signed installer increases the compatibility > with current MacOS versions (Catalina and Big Sur). I'm very > interested in feedback with these package files, as they're much > easier to install. > > Download links below. > Windows: > https://www.rickmurphy.net/lotw/tqsl-2.5.6.msi > <https://www.rickmurphy.net/lotw/tqsl-2.5.6.msi> > > Mac (64/32 bit, current systems) > https://www.rickmurphy.net/lotw/tqsl-2.5.6.pkg > <https://www.rickmurphy.net/lotw/tqsl-2.5.6.pkg> (Installer) > https://www.rickmurphy.net/lotw/tqsl-2.5.6.dmg > <https://www.rickmurphy.net/lotw/tqsl-2.5.6.dmg> (Disk image) > > Mac (Intel 386/Power PC legacy systems) > https://www.rickmurphy.net/lotw/tqsl-legacy-2.5.6.pkg > <https://www.rickmurphy.net/lotw/tqsl-legacy-2.5.6.pkg> (Installer) > https://www.rickmurphy.net/lotw/tqsl-legacy-2.5.6.dmg > <https://www.rickmurphy.net/lotw/tqsl-legacy-2.5.6.dmg> (Disk image) > > Linux/BSD: > https://www.rickmurphy.net/lotw/tqsl-2.5.6.tar.gz > <https://www.rickmurphy.net/lotw/tqsl-2.5.6.tar.gz> (source code only) > 73, > -Rick > -- > Rick Murphy, CISSP-ISSAP, K1MU/4, Annandale VA USA > > > _______________________________________________ > Trustedqsl-testing mailing list > Tru...@li... > https://lists.sourceforge.net/lists/listinfo/trustedqsl-testing |
From: Rick M. <k1...@ar...> - 2020-11-01 03:07:30
|
What is your suggested fix? openSUSE has this problem for multiple wxWidgets consumers. For example, from 2016: https://forum.audacityteam.org/viewtopic.php?t=89971&start=10 I'll be happy to upstream a fix, but this seems to be a deliberate choice by openSuSE that leads to compatibility issues. 73, -Rick On Sat, Oct 31, 2020 at 10:47 PM Walter Fey <dl...@da...> wrote: > Compilation for openSUSE 15.2 and Tumbleweed fails. > The build logs with the error at the end are added to this mail. > > 73, > Walter DL8FCL > > > Am 31.10.20 um 19:06 schrieb Rick Murphy: > > I've published a release candidate for TQSL 2.5.6 - details below. > > Defects Corrected: > 1. In cases where applications pass empty passwords on the command line > (-p ""), TQSL could ignore that password and handle the command > incorrectly. This was not the behavior prior to TQSL 2.5.5. > 2. Ask the user to save a log being edited in the ADIF editor when they > close the editor window. Previously, TQSL would discard the file. > 3. TQSL more accurately prints the line number of an ADIF file with an > error message. In the past, TQSL always reported the line containing the > end-of-record tag. > > In addition, TQSL now uses the word "Passphrase" to distinguish between > the password used for the LoTW site and the passphrase used to secure a > Callsign Certificate. > > TQSL now also has a Swedish localization, thanks to SM0LTV. The other > localizations have also been updated. > > A big change in the packaging for TQSL 2.5.6 for MacOS is the use of a > signed and notarized (by Apple) package file ".pkg" for installing TQSL on > a Mac. Having a signed installer increases the compatibility with current > MacOS versions (Catalina and Big Sur). I'm very interested in feedback with > these package files, as they're much easier to install. > > Download links below. > Windows: > https://www.rickmurphy.net/lotw/tqsl-2.5.6.msi > > Mac (64/32 bit, current systems) > https://www.rickmurphy.net/lotw/tqsl-2.5.6.pkg (Installer) > https://www.rickmurphy.net/lotw/tqsl-2.5.6.dmg (Disk image) > > Mac (Intel 386/Power PC legacy systems) > https://www.rickmurphy.net/lotw/tqsl-legacy-2.5.6.pkg (Installer) > https://www.rickmurphy.net/lotw/tqsl-legacy-2.5.6.dmg (Disk image) > > Linux/BSD: > https://www.rickmurphy.net/lotw/tqsl-2.5.6.tar.gz (source code only) > 73, > -Rick > -- > Rick Murphy, CISSP-ISSAP, K1MU/4, Annandale VA USA > > > _______________________________________________ > Trustedqsl-testing mailing lis...@li...https://lists.sourceforge.net/lists/listinfo/trustedqsl-testing > > _______________________________________________ > Trustedqsl-testing mailing list > Tru...@li... > https://lists.sourceforge.net/lists/listinfo/trustedqsl-testing > -- Rick Murphy, CISSP-ISSAP, K1MU/4, Annandale VA USA |
From: Rick M. <k1...@ar...> - 2020-11-01 13:08:21
|
I've reproduced this on an older version of openSUSE that I had a VM for already. Are you building against wxWidgets 2.x? Do you have 3.x libraries available? 2.x is going to be end-of-life soon if not already - 2.8.12, the latest 2.x release, came out in 2011. 73, -Rick On Sat, Oct 31, 2020 at 11:06 PM Rick Murphy <k1...@ar...> wrote: > What is your suggested fix? openSUSE has this problem for multiple > wxWidgets consumers. For example, from 2016: > https://forum.audacityteam.org/viewtopic.php?t=89971&start=10 > > I'll be happy to upstream a fix, but this seems to be a deliberate choice > by openSuSE that leads to compatibility issues. > 73, > -Rick > > > > On Sat, Oct 31, 2020 at 10:47 PM Walter Fey <dl...@da...> wrote: > >> Compilation for openSUSE 15.2 and Tumbleweed fails. >> The build logs with the error at the end are added to this mail. >> >> 73, >> Walter DL8FCL >> >> >> Am 31.10.20 um 19:06 schrieb Rick Murphy: >> >> I've published a release candidate for TQSL 2.5.6 - details below. >> >> Defects Corrected: >> 1. In cases where applications pass empty passwords on the command line >> (-p ""), TQSL could ignore that password and handle the command >> incorrectly. This was not the behavior prior to TQSL 2.5.5. >> 2. Ask the user to save a log being edited in the ADIF editor when they >> close the editor window. Previously, TQSL would discard the file. >> 3. TQSL more accurately prints the line number of an ADIF file with an >> error message. In the past, TQSL always reported the line containing the >> end-of-record tag. >> >> In addition, TQSL now uses the word "Passphrase" to distinguish between >> the password used for the LoTW site and the passphrase used to secure a >> Callsign Certificate. >> >> TQSL now also has a Swedish localization, thanks to SM0LTV. The other >> localizations have also been updated. >> >> A big change in the packaging for TQSL 2.5.6 for MacOS is the use of a >> signed and notarized (by Apple) package file ".pkg" for installing TQSL on >> a Mac. Having a signed installer increases the compatibility with current >> MacOS versions (Catalina and Big Sur). I'm very interested in feedback with >> these package files, as they're much easier to install. >> >> Download links below. >> Windows: >> https://www.rickmurphy.net/lotw/tqsl-2.5.6.msi >> >> Mac (64/32 bit, current systems) >> https://www.rickmurphy.net/lotw/tqsl-2.5.6.pkg (Installer) >> https://www.rickmurphy.net/lotw/tqsl-2.5.6.dmg (Disk image) >> >> Mac (Intel 386/Power PC legacy systems) >> https://www.rickmurphy.net/lotw/tqsl-legacy-2.5.6.pkg (Installer) >> https://www.rickmurphy.net/lotw/tqsl-legacy-2.5.6.dmg (Disk image) >> >> Linux/BSD: >> https://www.rickmurphy.net/lotw/tqsl-2.5.6.tar.gz (source code only) >> 73, >> -Rick >> -- >> Rick Murphy, CISSP-ISSAP, K1MU/4, Annandale VA USA >> >> >> _______________________________________________ >> Trustedqsl-testing mailing lis...@li...https://lists.sourceforge.net/lists/listinfo/trustedqsl-testing >> >> _______________________________________________ >> Trustedqsl-testing mailing list >> Tru...@li... >> https://lists.sourceforge.net/lists/listinfo/trustedqsl-testing >> > > > -- > Rick Murphy, CISSP-ISSAP, K1MU/4, Annandale VA USA > -- Rick Murphy, CISSP-ISSAP, K1MU/4, Annandale VA USA |
From: Rick M. <k1...@ar...> - 2020-11-01 18:08:08
|
This is an issue where TQSL is depending on an implicit conversion to wide characters that your system isn't allowing. Relying on implicit conversions can cause problems like this. I've checked in a correction to the repository. Patch to correct this is below. Thanks for reporting this. It wasn't at all what I thought. 73, -Rick diff --git a/apps/tqsl.cpp b/apps/tqsl.cpp index 1e9075c..f7a5d7d 100644 --- a/apps/tqsl.cpp +++ b/apps/tqsl.cpp @@ -745,7 +745,7 @@ class LogList : public wxLog { #if wxMAJOR_VERSION > 2 void LogList::DoLogText(const wxString& msg) { - const wxChar* szString(msg); + const wxChar* szString = msg.wc_str(); #else void LogList::DoLogString(const wxChar *szString, time_t) { static wxString msg(szString); @@ -789,7 +789,7 @@ class LogStderr : public wxLog { #if wxMAJOR_VERSION > 2 void LogStderr::DoLogText(const wxString& msg) { - const wxChar* szString(msg); + const wxChar* szString = msg.wc_str(); #else void LogStderr::DoLogString(const wxChar *szString, time_t) { static wxString msg(szString); @@ -5452,11 +5452,11 @@ QSLApp::OnInit() { wxString av = argv[0]; myArgv[0] = strdup(av.ToUTF8()); #else - myArgv[0] = strdup(argv[0]); + myArgv[0] = strdup(argv[0].ToUTF8()); #endif myArgc = 1; for (int i = 1; i < argc; i++) { - if ((const wxChar *)argv[i]) { + if ((const wxChar *)argv[i].mb_str().data()) { if ((i + 1) < argc) { wxString av1 = argv[i+1]; #if wxMAJOR_VERSION == 2 @@ -5471,9 +5471,9 @@ QSLApp::OnInit() { } origCommandLine += wxT(" "); #if wxMAJOR_VERSION == 2 - myArgv[myArgc] = strdup(wxString(argv[i]).ToUTF8());; + myArgv[myArgc] = strdup(wxString(argv[i]).ToUTF8()); #else - myArgv[myArgc] = strdup(argv[i]); + myArgv[myArgc] = strdup(argv[i].ToUTF8()); #endif #ifdef _WIN32 if (myArgv[myArgc][0] == '-' || myArgv[myArgc][0] == '/') On Sun, Nov 1, 2020 at 8:07 AM Rick Murphy <k1...@ar...> wrote: > I've reproduced this on an older version of openSUSE that I had a VM for > already. > Are you building against wxWidgets 2.x? Do you have 3.x libraries > available? 2.x is going to be end-of-life soon if not already - 2.8.12, > the latest 2.x release, came out in 2011. > 73, > -Rick > > On Sat, Oct 31, 2020 at 11:06 PM Rick Murphy <k1...@ar...> wrote: > >> What is your suggested fix? openSUSE has this problem for multiple >> wxWidgets consumers. For example, from 2016: >> https://forum.audacityteam.org/viewtopic.php?t=89971&start=10 >> >> I'll be happy to upstream a fix, but this seems to be a deliberate choice >> by openSuSE that leads to compatibility issues. >> 73, >> -Rick >> >> >> >> On Sat, Oct 31, 2020 at 10:47 PM Walter Fey <dl...@da...> wrote: >> >>> Compilation for openSUSE 15.2 and Tumbleweed fails. >>> The build logs with the error at the end are added to this mail. >>> >>> 73, >>> Walter DL8FCL >>> >>> >>> Am 31.10.20 um 19:06 schrieb Rick Murphy: >>> >>> I've published a release candidate for TQSL 2.5.6 - details below. >>> >>> Defects Corrected: >>> 1. In cases where applications pass empty passwords on the command line >>> (-p ""), TQSL could ignore that password and handle the command >>> incorrectly. This was not the behavior prior to TQSL 2.5.5. >>> 2. Ask the user to save a log being edited in the ADIF editor when they >>> close the editor window. Previously, TQSL would discard the file. >>> 3. TQSL more accurately prints the line number of an ADIF file with an >>> error message. In the past, TQSL always reported the line containing the >>> end-of-record tag. >>> >>> In addition, TQSL now uses the word "Passphrase" to distinguish between >>> the password used for the LoTW site and the passphrase used to secure a >>> Callsign Certificate. >>> >>> TQSL now also has a Swedish localization, thanks to SM0LTV. The other >>> localizations have also been updated. >>> >>> A big change in the packaging for TQSL 2.5.6 for MacOS is the use of a >>> signed and notarized (by Apple) package file ".pkg" for installing TQSL on >>> a Mac. Having a signed installer increases the compatibility with current >>> MacOS versions (Catalina and Big Sur). I'm very interested in feedback with >>> these package files, as they're much easier to install. >>> >>> Download links below. >>> Windows: >>> https://www.rickmurphy.net/lotw/tqsl-2.5.6.msi >>> >>> Mac (64/32 bit, current systems) >>> https://www.rickmurphy.net/lotw/tqsl-2.5.6.pkg (Installer) >>> https://www.rickmurphy.net/lotw/tqsl-2.5.6.dmg (Disk image) >>> >>> Mac (Intel 386/Power PC legacy systems) >>> https://www.rickmurphy.net/lotw/tqsl-legacy-2.5.6.pkg (Installer) >>> https://www.rickmurphy.net/lotw/tqsl-legacy-2.5.6.dmg (Disk image) >>> >>> Linux/BSD: >>> https://www.rickmurphy.net/lotw/tqsl-2.5.6.tar.gz (source code only) >>> 73, >>> -Rick >>> -- >>> Rick Murphy, CISSP-ISSAP, K1MU/4, Annandale VA USA >>> >>> >>> _______________________________________________ >>> Trustedqsl-testing mailing lis...@li...https://lists.sourceforge.net/lists/listinfo/trustedqsl-testing >>> >>> _______________________________________________ >>> Trustedqsl-testing mailing list >>> Tru...@li... >>> https://lists.sourceforge.net/lists/listinfo/trustedqsl-testing >>> >> >> >> -- >> Rick Murphy, CISSP-ISSAP, K1MU/4, Annandale VA USA >> > > > -- > Rick Murphy, CISSP-ISSAP, K1MU/4, Annandale VA USA > -- Rick Murphy, CISSP-ISSAP, K1MU/4, Annandale VA USA |
From: Walter F. <dl...@da...> - 2020-11-01 20:49:50
|
This patch fixes the build problem on all current openSUSE versions. Default wxWidgets version of Leap 15.1 and 15.2 is 3.0.3 , Tumbleweed has 3.1.4 Thank you for the fix. 73, Walter DL8FCL Am 01.11.20 um 18:07 schrieb Rick Murphy: > This is an issue where TQSL is depending on an implicit conversion to > wide characters that your system isn't allowing. Relying on implicit > conversions can cause problems like this. > > I've checked in a correction to the repository. Patch to correct this > is below. > > Thanks for reporting this. It wasn't at all what I thought. > 73, > -Rick > > diff --git a/apps/tqsl.cpp b/apps/tqsl.cpp > index 1e9075c..f7a5d7d 100644 > --- a/apps/tqsl.cpp > +++ b/apps/tqsl.cpp > @@ -745,7 +745,7 @@ class LogList : public wxLog { > > #if wxMAJOR_VERSION > 2 > void LogList::DoLogText(const wxString& msg) { > - const wxChar* szString(msg); > + const wxChar* szString = msg.wc_str(); > #else > void LogList::DoLogString(const wxChar *szString, time_t) { > static wxString msg(szString); > @@ -789,7 +789,7 @@ class LogStderr : public wxLog { > > #if wxMAJOR_VERSION > 2 > void LogStderr::DoLogText(const wxString& msg) { > - const wxChar* szString(msg); > + const wxChar* szString = msg.wc_str(); > #else > void LogStderr::DoLogString(const wxChar *szString, time_t) { > static wxString msg(szString); > @@ -5452,11 +5452,11 @@ QSLApp::OnInit() { > wxString av = argv[0]; > myArgv[0] = strdup(av.ToUTF8()); > #else > - myArgv[0] = strdup(argv[0]); > + myArgv[0] = strdup(argv[0].ToUTF8()); > #endif > myArgc = 1; > for (int i = 1; i < argc; i++) { > - if ((const wxChar *)argv[i]) { > + if ((const wxChar *)argv[i].mb_str().data()) { > if ((i + 1) < argc) { > wxString av1 = argv[i+1]; > #if wxMAJOR_VERSION == 2 > @@ -5471,9 +5471,9 @@ QSLApp::OnInit() { > } > origCommandLine += wxT(" "); > #if wxMAJOR_VERSION == 2 > - myArgv[myArgc] = > strdup(wxString(argv[i]).ToUTF8());; > + myArgv[myArgc] = > strdup(wxString(argv[i]).ToUTF8()); > #else > - myArgv[myArgc] = strdup(argv[i]); > + myArgv[myArgc] = strdup(argv[i].ToUTF8()); > #endif > #ifdef _WIN32 > if (myArgv[myArgc][0] == '-' || > myArgv[myArgc][0] == '/') > > On Sun, Nov 1, 2020 at 8:07 AM Rick Murphy <k1...@ar... > <mailto:k1...@ar...>> wrote: > > I've reproduced this on an older version of openSUSE that I had a > VM for already. > Are you building against wxWidgets 2.x? Do you have 3.x libraries > available? 2.x is going to be end-of-life soon if not already - > 2.8.12, the latest 2.x release, came out in 2011. > 73, > -Rick > > On Sat, Oct 31, 2020 at 11:06 PM Rick Murphy <k1...@ar... > <mailto:k1...@ar...>> wrote: > > What is your suggested fix? openSUSE has this problem for > multiple wxWidgets consumers. For example, from 2016: > https://forum.audacityteam.org/viewtopic.php?t=89971&start=10 > <https://forum.audacityteam.org/viewtopic.php?t=89971&start=10> > > I'll be happy to upstream a fix, but this seems to be a > deliberate choice by openSuSE that leads to compatibility issues. > 73, > -Rick > > > > On Sat, Oct 31, 2020 at 10:47 PM Walter Fey <dl...@da... > <mailto:dl...@da...>> wrote: > > Compilation for openSUSE 15.2 and Tumbleweed fails. > The build logs with the error at the end are added to this > mail. > > 73, > Walter DL8FCL > > > Am 31.10.20 um 19:06 schrieb Rick Murphy: >> I've published a release candidate for TQSL 2.5.6 - >> details below. >> >> Defects Corrected: >> 1. In cases where applications pass empty passwords on >> the command line (-p ""), TQSL could ignore that password >> and handle the command incorrectly. This was not the >> behavior prior to TQSL 2.5.5. >> 2. Ask the user to save a log being edited in the ADIF >> editor when they close the editor window. Previously, >> TQSL would discard the file. >> 3. TQSL more accurately prints the line number of an ADIF >> file with an error message. In the past, TQSL always >> reported the line containing the end-of-record tag. >> >> In addition, TQSL now uses the word "Passphrase" to >> distinguish between the password used for the LoTW site >> and the passphrase used to secure a Callsign Certificate. >> >> TQSL now also has a Swedish localization, thanks to >> SM0LTV. The other localizations have also been updated. >> >> A big change in the packaging for TQSL 2.5.6 for MacOS is >> the use of a signed and notarized (by Apple) package file >> ".pkg" for installing TQSL on a Mac. Having a signed >> installer increases the compatibility with current MacOS >> versions (Catalina and Big Sur). I'm very interested in >> feedback with these package files, as they're much easier >> to install. >> >> Download links below. >> Windows: >> https://www.rickmurphy.net/lotw/tqsl-2.5.6.msi >> <https://www.rickmurphy.net/lotw/tqsl-2.5.6.msi> >> >> Mac (64/32 bit, current systems) >> https://www.rickmurphy.net/lotw/tqsl-2.5.6.pkg >> <https://www.rickmurphy.net/lotw/tqsl-2.5.6.pkg> (Installer) >> https://www.rickmurphy.net/lotw/tqsl-2.5.6.dmg >> <https://www.rickmurphy.net/lotw/tqsl-2.5.6.dmg> (Disk image) >> >> Mac (Intel 386/Power PC legacy systems) >> https://www.rickmurphy.net/lotw/tqsl-legacy-2.5.6.pkg >> <https://www.rickmurphy.net/lotw/tqsl-legacy-2.5.6.pkg> >> (Installer) >> https://www.rickmurphy.net/lotw/tqsl-legacy-2.5.6.dmg >> <https://www.rickmurphy.net/lotw/tqsl-legacy-2.5.6.dmg> >> (Disk image) >> >> Linux/BSD: >> https://www.rickmurphy.net/lotw/tqsl-2.5.6.tar.gz >> <https://www.rickmurphy.net/lotw/tqsl-2.5.6.tar.gz> >> (source code only) >> 73, >> -Rick >> -- >> Rick Murphy, CISSP-ISSAP, K1MU/4, Annandale VA USA >> >> >> _______________________________________________ >> Trustedqsl-testing mailing list >> Tru...@li... <mailto:Tru...@li...> >> https://lists.sourceforge.net/lists/listinfo/trustedqsl-testing <https://lists.sourceforge.net/lists/listinfo/trustedqsl-testing> > _______________________________________________ > Trustedqsl-testing mailing list > Tru...@li... > <mailto:Tru...@li...> > https://lists.sourceforge.net/lists/listinfo/trustedqsl-testing > <https://lists.sourceforge.net/lists/listinfo/trustedqsl-testing> > > > > -- > Rick Murphy, CISSP-ISSAP, K1MU/4, Annandale VA USA > > > > -- > Rick Murphy, CISSP-ISSAP, K1MU/4, Annandale VA USA > > > > -- > Rick Murphy, CISSP-ISSAP, K1MU/4, Annandale VA USA > > > _______________________________________________ > Trustedqsl-testing mailing list > Tru...@li... > https://lists.sourceforge.net/lists/listinfo/trustedqsl-testing |
From: Rick M. <k1...@ar...> - 2020-11-02 00:01:56
|
Walter, Makes sense - there's probably some change in 3.1.4 that keeps this from building, but it's good to catch this before it's released. 73, -Rick On Sun, Nov 1, 2020 at 3:49 PM Walter Fey <dl...@da...> wrote: > This patch fixes the build problem on all current openSUSE versions. > > Default wxWidgets version of Leap 15.1 and 15.2 is 3.0.3 , Tumbleweed has > 3.1.4 > > Thank you for the fix. > > 73, Walter DL8FCL > > > Am 01.11.20 um 18:07 schrieb Rick Murphy: > > This is an issue where TQSL is depending on an implicit conversion to wide > characters that your system isn't allowing. Relying on implicit conversions > can cause problems like this. > > I've checked in a correction to the repository. Patch to correct this is > below. > > Thanks for reporting this. It wasn't at all what I thought. > 73, > -Rick > > diff --git a/apps/tqsl.cpp b/apps/tqsl.cpp > index 1e9075c..f7a5d7d 100644 > --- a/apps/tqsl.cpp > +++ b/apps/tqsl.cpp > @@ -745,7 +745,7 @@ class LogList : public wxLog { > > #if wxMAJOR_VERSION > 2 > void LogList::DoLogText(const wxString& msg) { > - const wxChar* szString(msg); > + const wxChar* szString = msg.wc_str(); > #else > void LogList::DoLogString(const wxChar *szString, time_t) { > static wxString msg(szString); > @@ -789,7 +789,7 @@ class LogStderr : public wxLog { > > #if wxMAJOR_VERSION > 2 > void LogStderr::DoLogText(const wxString& msg) { > - const wxChar* szString(msg); > + const wxChar* szString = msg.wc_str(); > #else > void LogStderr::DoLogString(const wxChar *szString, time_t) { > static wxString msg(szString); > @@ -5452,11 +5452,11 @@ QSLApp::OnInit() { > wxString av = argv[0]; > myArgv[0] = strdup(av.ToUTF8()); > #else > - myArgv[0] = strdup(argv[0]); > + myArgv[0] = strdup(argv[0].ToUTF8()); > #endif > myArgc = 1; > for (int i = 1; i < argc; i++) { > - if ((const wxChar *)argv[i]) { > + if ((const wxChar *)argv[i].mb_str().data()) { > if ((i + 1) < argc) { > wxString av1 = argv[i+1]; > #if wxMAJOR_VERSION == 2 > @@ -5471,9 +5471,9 @@ QSLApp::OnInit() { > } > origCommandLine += wxT(" "); > #if wxMAJOR_VERSION == 2 > - myArgv[myArgc] = > strdup(wxString(argv[i]).ToUTF8());; > + myArgv[myArgc] = > strdup(wxString(argv[i]).ToUTF8()); > #else > - myArgv[myArgc] = strdup(argv[i]); > + myArgv[myArgc] = strdup(argv[i].ToUTF8()); > #endif > #ifdef _WIN32 > if (myArgv[myArgc][0] == '-' || myArgv[myArgc][0] > == '/') > > On Sun, Nov 1, 2020 at 8:07 AM Rick Murphy <k1...@ar...> wrote: > >> I've reproduced this on an older version of openSUSE that I had a VM for >> already. >> Are you building against wxWidgets 2.x? Do you have 3.x libraries >> available? 2.x is going to be end-of-life soon if not already - 2.8.12, >> the latest 2.x release, came out in 2011. >> 73, >> -Rick >> >> On Sat, Oct 31, 2020 at 11:06 PM Rick Murphy <k1...@ar...> wrote: >> >>> What is your suggested fix? openSUSE has this problem for multiple >>> wxWidgets consumers. For example, from 2016: >>> https://forum.audacityteam.org/viewtopic.php?t=89971&start=10 >>> >>> I'll be happy to upstream a fix, but this seems to be a deliberate >>> choice by openSuSE that leads to compatibility issues. >>> 73, >>> -Rick >>> >>> >>> >>> On Sat, Oct 31, 2020 at 10:47 PM Walter Fey <dl...@da...> wrote: >>> >>>> Compilation for openSUSE 15.2 and Tumbleweed fails. >>>> The build logs with the error at the end are added to this mail. >>>> >>>> 73, >>>> Walter DL8FCL >>>> >>>> >>>> Am 31.10.20 um 19:06 schrieb Rick Murphy: >>>> >>>> I've published a release candidate for TQSL 2.5.6 - details below. >>>> >>>> Defects Corrected: >>>> 1. In cases where applications pass empty passwords on the command line >>>> (-p ""), TQSL could ignore that password and handle the command >>>> incorrectly. This was not the behavior prior to TQSL 2.5.5. >>>> 2. Ask the user to save a log being edited in the ADIF editor when they >>>> close the editor window. Previously, TQSL would discard the file. >>>> 3. TQSL more accurately prints the line number of an ADIF file with an >>>> error message. In the past, TQSL always reported the line containing the >>>> end-of-record tag. >>>> >>>> In addition, TQSL now uses the word "Passphrase" to distinguish between >>>> the password used for the LoTW site and the passphrase used to secure a >>>> Callsign Certificate. >>>> >>>> TQSL now also has a Swedish localization, thanks to SM0LTV. The other >>>> localizations have also been updated. >>>> >>>> A big change in the packaging for TQSL 2.5.6 for MacOS is the use of a >>>> signed and notarized (by Apple) package file ".pkg" for installing TQSL on >>>> a Mac. Having a signed installer increases the compatibility with current >>>> MacOS versions (Catalina and Big Sur). I'm very interested in feedback with >>>> these package files, as they're much easier to install. >>>> >>>> Download links below. >>>> Windows: >>>> https://www.rickmurphy.net/lotw/tqsl-2.5.6.msi >>>> >>>> Mac (64/32 bit, current systems) >>>> https://www.rickmurphy.net/lotw/tqsl-2.5.6.pkg (Installer) >>>> https://www.rickmurphy.net/lotw/tqsl-2.5.6.dmg (Disk image) >>>> >>>> Mac (Intel 386/Power PC legacy systems) >>>> https://www.rickmurphy.net/lotw/tqsl-legacy-2.5.6.pkg (Installer) >>>> https://www.rickmurphy.net/lotw/tqsl-legacy-2.5.6.dmg (Disk image) >>>> >>>> Linux/BSD: >>>> https://www.rickmurphy.net/lotw/tqsl-2.5.6.tar.gz (source code only) >>>> 73, >>>> -Rick >>>> -- >>>> Rick Murphy, CISSP-ISSAP, K1MU/4, Annandale VA USA >>>> >>>> >>>> _______________________________________________ >>>> Trustedqsl-testing mailing lis...@li...https://lists.sourceforge.net/lists/listinfo/trustedqsl-testing >>>> >>>> _______________________________________________ >>>> Trustedqsl-testing mailing list >>>> Tru...@li... >>>> https://lists.sourceforge.net/lists/listinfo/trustedqsl-testing >>>> >>> >>> >>> -- >>> Rick Murphy, CISSP-ISSAP, K1MU/4, Annandale VA USA >>> >> >> >> -- >> Rick Murphy, CISSP-ISSAP, K1MU/4, Annandale VA USA >> > > > -- > Rick Murphy, CISSP-ISSAP, K1MU/4, Annandale VA USA > > > _______________________________________________ > Trustedqsl-testing mailing lis...@li...https://lists.sourceforge.net/lists/listinfo/trustedqsl-testing > > _______________________________________________ > Trustedqsl-testing mailing list > Tru...@li... > https://lists.sourceforge.net/lists/listinfo/trustedqsl-testing > -- Rick Murphy, CISSP-ISSAP, K1MU/4, Annandale VA USA |