Re: [Trustedqsl-testing] OpenSSL 3.0.0

[Greg T. <gd...@le...>]

Richard Shaw <hob...@gm...> writes:

> Index: tqsl-2.5.9/src/openssl_cert.cpp
> ===================================================================
> --- tqsl-2.5.9.orig/src/openssl_cert.cpp
> +++ tqsl-2.5.9/src/openssl_cert.cpp
> @@ -4285,7 +4285,7 @@ static int
>  tqsl_ssl_error_is_nofile() {
>   unsigned long l = ERR_peek_error();
>   if (tQSL_Error == TQSL_OPENSSL_ERROR &&
> - ERR_GET_LIB(l) == ERR_LIB_SYS && ERR_GET_FUNC(l) == SYS_F_FOPEN)
> + ERR_GET_LIB(l) == ERR_LIB_SYS == SYS_F_FOPEN)
>   return 1;
>   if (tQSL_Error == TQSL_SYSTEM_ERROR && tQSL_Errno == ENOENT)
>   return 1;

Did you also meen to remove " == SYS_F_FOPEN"?

Is there really no semantics change from this?  (It seems sensible to
adjust, but I am not entirely following.

> I also have patches I maintain to clean up rpath/lib install location and
> to provide a soversion for the tqsl library (required by Fedora).

I'd be interested to see the rpath/lib patch.  pkgsrc norms are to have
RPATH of /usr/pkg/lib set in /usr/pkg/foo as /usr/pkg (or whatever) is
not in the default search path.  I know that various packaging systems
have very different rpath rules, and I think that leads to a need to be
able to configure the build for the varying environments.

73 de n1dam