Re: [Trustedqsl-testing] TQSL 2.5.9 beta release available for testing

[Greg T. <gd...@le...>]

  https://www.rickmurphy.net/lotw/tqsl-2.5.9.tar.gz (Linux/BSD)

This is the expected source tarball and that's I tested.


I locally updated the pkgsrc package to 2.5.9 and it builds ok on NetBSD
9 amd64, and starts up.

While cleaning up our patches, I noticed that there we added a
NetBSD-specific include to get PATH_MAX defined, which made me notice
two things:

  There's a TQSL_MAX_PATH_LEN set to 256, and I'm not sure why this
  isn't system PATH_MAX.  But I think PATH_MAX has to be >=1024, so this
  merely results in some crayz long but technically legal paths not
  being ok, and that seems highly unlikely to bother people.

  In openssl_cert.cpp, there are ifdefs to define PATH_MAX if undefined,
  at line 3124.  This seems slightly dangerous because POSIX more or
  less requires PATH_MAX and thus I think it's best to ifdef remediation
  for that on systems that are known to need it.  And, I don't see an
  include of <limits.h>, which is what POSIX says one needs to get
  PATH_MAX defined.  However the actual spec is messy, and there's a
  notion that code might just rely on the minimum value.  But, I think
  code that uses PATH_MAX should include limits.h. At the moment this
  problem seems theoretical.
  https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/limits.h.html

And this is of course a small list of small nits, which is a great
testing report...

73 de n1dam