Menu

#42 Trousers should be able to terminate even if clients hold connections open

open
nobody
None
5
2015-09-15
2015-09-15
Mike Gerow
No

I'm seeing this issue in trousers 0.3.11.2 but looking through the current code doesn't seem to suggest this has been changed at all.

If I have a client that holds open a session continuously it will block trousers from shutting down when it gets SIGTERM because tcsd_threads_final waits on all the threads which are blocked on the socket connecting them to clients. It would be nice if trousers could still cleanly shutdown in this case, even a solution where it waits for a bit for threads to finish before just closing the connections would be nice too.

It seems the client returns TSS_E_COMM_ERROR if I SIGQUIT trousers. I'm not certain what the spec says about this kind of situation, but that seems a decent enough signal to just re-open the connection with.

Discussion


Log in to post a comment.