#56 Sets focus on the Ok button

closed-accepted
nobody
None
5
2012-08-21
2012-08-16
Hakon
No

In the select casualties panel, I often find that the default casualties selection is perfect. Currently I have to use the mouse to click on Ok to accept the casualties. With this patch, the focus will be on the Ok button and I can hit space. Makes it a little easier to plow through many battles and battle rounds.

Also, adds a documentation of a param, forgotten in earlier patch.

Discussion

  • Hakon

    Hakon - 2012-08-16

    svn diff output

     
  • Chris Duncan

    Chris Duncan - 2012-08-16

    i think there was a previous patch for this sort of thing, but that it was rejected because having to click stops people from making accidents. i'm a little undecided about it.

     
  • Hakon

    Hakon - 2012-08-17

    Found it: 3351371. Seems like people didn't like it. On the other hand, most other popups have a default action.

    How about setting the focus on Ok if not playing online? From related bugs I found, the main concern was writing in the chat window. I haven't yet played online, so I wouldn't know. In single-user mode one doesn't chat, and one may save frequently, so there's little concern for mistakes.

     
  • Hakon

    Hakon - 2012-08-17

    Related to this is whether one could start using Enter for selecting rather than Space. Space is slightly easier to hit, but is used much more heavily in e.g. chat. If this sounds like a good idea, I could look into how difficult this is to implement.

    Or, perhaps we could support shortcuts. E.g. in a Ok/Cancel pop-up, Alt-O could choose OK, Alt-C to Cancel. I think the window would need to be in focus.

    Let me more clearly state the 3 reasons I would prefer this patch, or something like it.
    - The default selection of casualties is exactly what I choose, so 95% of the times the only thing I have to do is to click Ok. If the focus is on Ok, I would save some time and effort.
    - It is consistent with all other popups. All of them have default actions. I don't see what makes the casualties popup so special, many of the other popups would also be damaging if you choose wrongly. But again, the AI is pretty good.
    - I'm using a laptop with a trackpad and trackpoint, and my fingers hurts after an hours of play with TripleA.

     
  • Chris Duncan

    Chris Duncan - 2012-08-17

    it would probably be a great idea to have all shortcuts and keyboard commands mapped and set somewhere, then the user could change the keys and commands just like a real video game. this might be way too much work though.

    we could make an option in the menu bar similar to the "confirm enemy casualties" option.
    call it "confirm own casualties" or something. make sure it defaults to true.

     
  • Hakon

    Hakon - 2012-08-18

    svn diff output

     
  • Hakon

    Hakon - 2012-08-18

    Good idea, see new patch.

     
  • Chris Duncan

    Chris Duncan - 2012-08-21

    accepted

     
  • Chris Duncan

    Chris Duncan - 2012-08-21
    • status: open --> closed-accepted
     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks