Menu
▾
▴
Re: [Triplea-develop] Italy as 6th Player
|
From: NeKromancer -- G. <nek...@co...> - 2004-10-09 06:55:10
|
Are you looking at the CVS from the source forge cvs repository page, the one on the project home page.. I have found that not to be updated as quick. I think I tagged u0-5-0-release without the italy image units but with the italian code changes. The code changes were done in the FlagIconImageFactory and TerritoryImageFactory, one tiny addition made in another file for which I forget. I forgot to add the Italian images ... the ones in /data/games/strategy/image/images/units/Italians cos I forgot to run cvs add Italians before doing a cvs commit. I thought the commit would automatically add new files, though I was wrong. But I just added them a few hours ago. On Sat, 2004-10-09 at 01:33, Ali Ibrahim wrote: > Hi, > > > I stil cannot see the italy variant game? Has that been checked into CVS? By > the way did you make sure you were in the root directory before running the > cvs tag command? Because I think you successfully tagged some of the code > base just not all. Anyway, I think that has been cleared up. I was just > confused because I can't see the italy variant files. > > Regards, > > Ali Ibrahim > > > >From: NeKromancer -- George <nek...@co...> > >Reply-To: tri...@li... > >To: tri...@li... > >Subject: Re: [Triplea-develop] Italy as 6th Player > >Date: Sat, 09 Oct 2004 00:46:39 -0500 > > > >I just updated the CVS with the italian images. Forgot to before.. but > >they are correct now. With the proper dark gray color. > > > >As for the tagging. I just did what you suggested from that time you > >told me to tag releases. Just like I did with u0-4-9-release I did the > >same with u0-5-0-release. Ran the cvs tag command you gave me. > > > >What we been doing all this time, and I believe since before 0.4.9 was > >we just update the cvs with our changes and all that. Then our release > >would be a "good" version of the CVS code. It's how we did with 0.4.9. > >Except I tagged it after we released it (by your suggestion). > > > >So in turn of keeping things like this. After doing the Italy changes, > >maybe 3 or 4 lines of code were changed. I tagged and released it. Any > >other changes were just done as usual as was done before. > > > >Though, I dunno, if you think something should be done differently... I > >don't know how much of a drastic change we're talking about here. If > >it's something minor and you are sure you can do it without any > >consequences.. or not, then I guess go ahead and do it with sgb's > >permission. > > > >Personally I wouldn't mind, because it would be your responsibility if > >anything should happen. Though I Don't think anything bad will, but cos > >it's sgb's baby, I'd rather you asked him and get the OK from him first. > > > >Other than that.. update the cvs code as normal... we been doing that > >for a while without any glitches. > > > > > >On Fri, 2004-10-08 at 21:44, Ali Ibrahim wrote: > > > Hi, > > > > > > I was updating the code tonight and I noticed that the new Italy changes > > > are on a different branch. Was that on purpose? I think it would be best > > > if all development was on the main branch for now to avoid confusion. I > > > also tried to tag the code with u0-5-0-release but it appears some > > > subset of the files have this as a branch. Once this is cleared up I can > > > start coding again. Changes on the branch can be merge into the main > > > trunk using CVS. One can read more about this on the online CVS > > > documentation (I can do this once I get the ok that is this is not a > > > desired thing). > > > > > > Regards, > > > > > > Ali Ibrahim > > > > > > NeKromancer -- George wrote: > > > > > > >Just to keep things official its best to repeat stuff in the mailing > > > >list. Better to keep track of stuff and damn handy when writing the > > > >changelog :) > > > > > > > >I added italy as 6th player. Works fine. Fixed a bug or two while I was > > > >at it. When it is fully functioning I will have it use an other revised > > > >map. > > > > > > > >Here is a thread reference > > > >http://maddlinks.com/triplea/viewtopic.php?p=756#756 > > > > > > > >I will update the CVS with this once I get it fully working. > > > > > > > > > > > > > > > > > > > > > > > > ------------------------------------------------------- > > > This SF.net email is sponsored by: IT Product Guide on ITManagersJournal > > > Use IT products in your business? Tell us what you think of them. Give > >us > > > Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out > >more > > > http://productguide.itmanagersjournal.com/guidepromo.tmpl > > > _______________________________________________ > > > Triplea-developers mailing list > > > Tri...@li... > > > https://lists.sourceforge.net/lists/listinfo/triplea-developers > >-- > >NeKromancer (also known as George) > >nek...@co... > > > >"Everything is never what it seems" > >"Followers believe, but leaders are the believed" > >"People are willing to abandon you, learning disabilities won't" > > > > > > > >------------------------------------------------------- > >This SF.net email is sponsored by: IT Product Guide on ITManagersJournal > >Use IT products in your business? Tell us what you think of them. Give us > >Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more > >http://productguide.itmanagersjournal.com/guidepromo.tmpl > >_______________________________________________ > >Triplea-developers mailing list > >Tri...@li... > >https://lists.sourceforge.net/lists/listinfo/triplea-developers > > _________________________________________________________________ > Express yourself instantly with MSN Messenger! Download today - it's FREE! > http://messenger.msn.click-url.com/go/onm00200471ave/direct/01/ > > > > ------------------------------------------------------- > This SF.net email is sponsored by: IT Product Guide on ITManagersJournal > Use IT products in your business? Tell us what you think of them. Give us > Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more > http://productguide.itmanagersjournal.com/guidepromo.tmpl > _______________________________________________ > Triplea-developers mailing list > Tri...@li... > https://lists.sourceforge.net/lists/listinfo/triplea-developers -- NeKromancer (also known as George) nek...@co... "Everything is never what it seems" "Followers believe, but leaders are the believed" "People are willing to abandon you, learning disabilities won't" |