Menu
▾
▴
Re: [Treebase-devel] time to update TreeBase contributor page?
|
From: Hilmar L. <hl...@ne...> - 2013-01-22 13:07:56
|
I have now copied the main trunk to branches/simple-search-UI, undone the commits 1084 through 1091 on the main trunk, and undone commits 1092 through 1095 on the simple-search-UI branch (so that the problematics series of commits are the only ones on that branch after branching off). I can't test whether the main trunk builds correctly now - could someone check that? -hilmar On Jan 16, 2013, at 4:28 AM, Rutger Vos wrote: > If they can be forked off that would be a good thing - I apologize for the mess, but it is actually good enough to keep in a branch somewhere so that some day, somebody might return to it. The idea was to make the search interfaces a lot simpler. > > > On Tue, Jan 15, 2013 at 8:29 PM, Hilmar Lapp <hl...@ne...> wrote: > > On Jan 14, 2013, at 6:03 PM, William Piel wrote: > >> Rutger's additions (revisions 1085-1093) need to be forked off and reintroduced later when some other problems that they introduce can be fixed, and the current state of the code rewound to revision 1084. > > > In the svn log I can see Rutger's changes only go to r1091: > > ------------------------------------------------------------------------ > r1084 | rvos | 2012-02-21 07:52:13 -0500 (Tue, 21 Feb 2012) | 1 line > > Made link to plus icon relative. Trivial commit. > ------------------------------------------------------------------------ > r1085 | rvos | 2012-02-21 17:38:31 -0500 (Tue, 21 Feb 2012) | 1 line > > Defensive code against NPEs > ------------------------------------------------------------------------ > r1086 | rvos | 2012-02-22 14:24:32 -0500 (Wed, 22 Feb 2012) | 1 line > > Deploying simple search box for all searches. > ------------------------------------------------------------------------ > r1087 | rvos | 2012-02-23 10:25:03 -0500 (Thu, 23 Feb 2012) | 1 line > > Removing code dealing with old-style search forms > ------------------------------------------------------------------------ > r1088 | rvos | 2012-02-23 10:43:14 -0500 (Thu, 23 Feb 2012) | 1 line > > Added test to ensure we don't get NullPointerExceptions > ------------------------------------------------------------------------ > r1089 | rvos | 2012-02-23 13:59:11 -0500 (Thu, 23 Feb 2012) | 1 line > > Correcting a bug I introduced: onSubmit() is also visited when buttons that modify the results set are pressed (i.e. there is no CQL query to run). In such cases handling the request should be delegated to super.onSubmit(). > ------------------------------------------------------------------------ > r1090 | rvos | 2012-02-23 14:07:30 -0500 (Thu, 23 Feb 2012) | 1 line > > Actually, we should probably check if query is an empty string (but not null). > ------------------------------------------------------------------------ > r1091 | rvos | 2012-02-23 15:03:22 -0500 (Thu, 23 Feb 2012) | 1 line > > This commit should fix the NPE we were getting at SearchResultsFrozen.java:41 because the result set should now no longer contain null values (it could be an empty set, though). To ensure that this is so and everything behaves as it should I am removing the cludge around line 176. > ------------------------------------------------------------------------ > r1092 | sfrgpiel | 2012-04-03 10:24:26 -0400 (Tue, 03 Apr 2012) | 1 line > > Fixing broken links, fixing spelling, etc. > ------------------------------------------------------------------------ > r1093 | hshyket | 2012-05-25 11:25:44 -0400 (Fri, 25 May 2012) | 1 line > > Removing Caching > ------------------------------------------------------------------------ > r1094 | hlapp | 2012-06-11 14:10:38 -0400 (Mon, 11 Jun 2012) | 2 lines > > Fixed spelling error reported by Michael Jones. > > ------------------------------------------------------------------------ > r1095 | hshyket | 2012-06-15 11:19:11 -0400 (Fri, 15 Jun 2012) | 1 line > > Updating PostgreSQL dependency to 8.4. Excluding geronimo-servlet and servlet-api from dependecies. > ------------------------------------------------------------------------ > > Should r1085-r1091 be excised? > > -hilmar > > -- > =========================================================== > : Hilmar Lapp -:- Durham, NC -:- informatics.nescent.org : > =========================================================== > > > > > ------------------------------------------------------------------------------ > Master SQL Server Development, Administration, T-SQL, SSAS, SSIS, SSRS > and more. Get SQL Server skills now (including 2012) with LearnDevNow - > 200+ hours of step-by-step video tutorials by Microsoft MVPs and experts. > SALE $99.99 this month only - learn more at: > http://p.sf.net/sfu/learnmore_122512 > _______________________________________________ > Treebase-devel mailing list > Tre...@li... > https://lists.sourceforge.net/lists/listinfo/treebase-devel > > > > > -- > Dr. Rutger A. Vos > Bioinformaticist > NCB Naturalis > Visiting address: Office A109, Einsteinweg 2, 2333 CC, Leiden, the Netherlands > Mailing address: Postbus 9517, 2300 RA, Leiden, the Netherlands > http://rutgervos.blogspot.com -- =========================================================== : Hilmar Lapp -:- Durham, NC -:- informatics.nescent.org : =========================================================== |
