Re: [Treebase-devel] time to update TreeBase contributor page?

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 422-6466

On Jan 14, 2013, at 6:03 PM, William Piel wrote:

> Rutger's additions (revisions 1085-1093) need to be forked off and reintroduced later when some other problems that they introduce can be fixed, and the current state of the code rewound to revision 1084. 

In the svn log I can see Rutger's changes only go to r1091:

------------------------------------------------------------------------
r1084 | rvos | 2012-02-21 07:52:13 -0500 (Tue, 21 Feb 2012) | 1 line

Made link to plus icon relative. Trivial commit.
------------------------------------------------------------------------
r1085 | rvos | 2012-02-21 17:38:31 -0500 (Tue, 21 Feb 2012) | 1 line

Defensive code against NPEs
------------------------------------------------------------------------
r1086 | rvos | 2012-02-22 14:24:32 -0500 (Wed, 22 Feb 2012) | 1 line

Deploying simple search box for all searches.
------------------------------------------------------------------------
r1087 | rvos | 2012-02-23 10:25:03 -0500 (Thu, 23 Feb 2012) | 1 line

Removing code dealing with old-style search forms
------------------------------------------------------------------------
r1088 | rvos | 2012-02-23 10:43:14 -0500 (Thu, 23 Feb 2012) | 1 line

Added test to ensure we don't get NullPointerExceptions
------------------------------------------------------------------------
r1089 | rvos | 2012-02-23 13:59:11 -0500 (Thu, 23 Feb 2012) | 1 line

Correcting a bug I introduced: onSubmit() is also visited when buttons that modify the results set are pressed (i.e. there is no CQL query to run). In such cases handling the request should be delegated to super.onSubmit().
------------------------------------------------------------------------
r1090 | rvos | 2012-02-23 14:07:30 -0500 (Thu, 23 Feb 2012) | 1 line

Actually, we should probably check if query is an empty string (but not null).
------------------------------------------------------------------------
r1091 | rvos | 2012-02-23 15:03:22 -0500 (Thu, 23 Feb 2012) | 1 line

This commit should fix the NPE we were getting at SearchResultsFrozen.java:41 because the result set should now no longer contain null values (it could be an empty set, though). To ensure that this is so and everything behaves as it should I am removing the cludge around line 176.
------------------------------------------------------------------------
r1092 | sfrgpiel | 2012-04-03 10:24:26 -0400 (Tue, 03 Apr 2012) | 1 line

Fixing broken links, fixing spelling, etc. 
------------------------------------------------------------------------
r1093 | hshyket | 2012-05-25 11:25:44 -0400 (Fri, 25 May 2012) | 1 line

Removing Caching
------------------------------------------------------------------------
r1094 | hlapp | 2012-06-11 14:10:38 -0400 (Mon, 11 Jun 2012) | 2 lines

Fixed spelling error reported by Michael Jones.

------------------------------------------------------------------------
r1095 | hshyket | 2012-06-15 11:19:11 -0400 (Fri, 15 Jun 2012) | 1 line

Updating PostgreSQL dependency to 8.4.  Excluding geronimo-servlet and servlet-api from dependecies.
------------------------------------------------------------------------

Should r1085-r1091 be excised?

	-hilmar

-- 
===========================================================
: Hilmar Lapp  -:- Durham, NC -:- informatics.nescent.org :
===========================================================