From: youjun g. <you...@ya...> - 2009-12-10 19:45:57
|
Sorry, I think I failed to describe this issue clearly in last email. We have 3 Type of citations: type "A" article; type "B" book; type "I" inbook (charpter?) In database they are all in the same table (citation) with column "type" mark their catogory (In java they are 4 different types). I found 4 type "B" citations records in table citation.treebase-dev. 2 of them have null value on column "tittle" , the other 2 have null value on column "booktittle". So return "booktittle" on type "B" will also cause null. Youjun On Thu, Dec 10, 2009 at 11:17 AM, youjun guo <you...@ya...> wrote: > Hi, Rutger, > > I git your comments on this issue: > > Added a getTitle() override. We always want getTitle() to return something. > For ArticleCitations, this field would normally be set with the name of the > > article. For InBookCitation, this field is populated with the section title, > so InBookCitation.getSectionTitle() calls the getTitle() method defined here, > from whence we need to go up the inheritance tree to the parent Citation class. > > For BookCitations, the title field is unset, so we return the BookTitle field > instead. This should resolve issue #2903172. > > > I am working on this bug: [ treebase-Bugs-2902650 ] Book titles don't > appear under study tab and found totally 4 published citations records in > our citation.treebase-dev. Two of them have booktiltle without tittle, and > the other 2 have tilttle without booktittle. So > "return the BookTitle field" may cause new problem. > > We may need to fix the table data, or return tiltte/booktittle whichever is > not null. > > Youjun > >> >> >> > |