[Treebase-guts] SF.net SVN: treebase:[43] trunk/treebase-core/src/main/perl/lib/CIPRES/ TreeBase/RecDumper.pm

[<mjd...@us...>]

Revision: 43
          http://treebase.svn.sourceforge.net/treebase/?rev=43&view=rev
Author:   mjdominus
Date:     2009-06-11 18:04:40 +0000 (Thu, 11 Jun 2009)

Log Message:
-----------
clean up messy quotation marks, remove unused comment

Modified Paths:
--------------
    trunk/treebase-core/src/main/perl/lib/CIPRES/TreeBase/RecDumper.pm

Modified: trunk/treebase-core/src/main/perl/lib/CIPRES/TreeBase/RecDumper.pm
===================================================================
--- trunk/treebase-core/src/main/perl/lib/CIPRES/TreeBase/RecDumper.pm	2009-06-11 08:37:48 UTC (rev 42)
+++ trunk/treebase-core/src/main/perl/lib/CIPRES/TreeBase/RecDumper.pm	2009-06-11 18:04:40 UTC (rev 43)
@@ -1,7 +1,7 @@
 package CIPRES::TreeBase::RecDumper;
 use Carp 'croak';
 
-# LOB fields should be removed from fieldlist and handled separately
+# XXX LOB fields should be removed from fieldlist and handled separately
 sub new {
     my $class = shift;
     my %arg = @_;
@@ -12,7 +12,7 @@
     my $self = { 
     	'F' => \@fieldnames, 
     	'X' => $X, 
-    	'N' => '"'.$tn.'"', 
+    	'N' => $tn,
     	'T' => $ct 
     };
     bless $self => $class;
@@ -27,9 +27,8 @@
 
 sub _initialize {
     my $self = shift;
-    my $fieldlist = join ", ", map { "\"$_\"" } @{$self->{F}}; 
-    # Need to escape certain field names here
-    $self->{'PREFIX'} = qq{INSERT INTO $self->{N} ($fieldlist) VALUES (};
+    my $fieldlist = join ", ", map qq{"$_"}, @{$self->{F}}; 
+    $self->{'PREFIX'} = qq{INSERT INTO "$self->{N}" ($fieldlist) VALUES (};
     $self->{'SUFFIX'} = qq{);\n}; # XXX added closing semicolon
     return;
 }
@@ -52,7 +51,7 @@
 
 # Format metadata into a create statement and return (or write) the result
 sub dump_create {
-	my $create = 'CREATE TABLE ' . $self->{'N'} . ";\n";
+	my $create = qq{CREATE TABLE "$self->{'N'}";\n};
 	return print {$self->{'OUT'}} $create if $self->{'OUT'};
 	return $create;		
 }


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.