Re: [tpmdd-devel] tpm.c: export of tpm_dev_release() causes section type conflict in ppc builds

[Tony C. <tc...@re...>]

On 05/27/2013 01:38 PM, Tony Camuso wrote:
> drivers/char/tpm/tpm.c:1179: error: __ksymtab_tpm_dev_release causes a section type conflict
> drivers/char/tpm/tpm.c:1179: error: __ksymtab_tpm_dev_release causes a section type conflict
> make[3]: *** [drivers/char/tpm/tpm.o] Error 1
> make[2]: *** [drivers/char/tpm] Error 2
> 
> This error is due to exporting a symbol that has been defined as static,
> and was introduced by the following commit.
> 
> commit 81198078d7da4240f3cbfc2c6a8ea6cd417f51a7
> Author: Xiaoyan Zhang <xia...@in...>
> Date:   Thu Aug 29 20:39:11 2013 +0800
> 
> I would submit a patch, but I cannot determine from the code
> whether the submitter of commit 8119807 really wanted to declare
> this function as static or really wanted to export it. 
> 
> Please advise, so I can test and submit the one-liner patch
> to fix it. 
> 

By digging back through the git log, I was able to determine that
this function was intended to be exported.