From: Theodore T. <ty...@MI...> - 2008-11-17 20:29:18
|
On Mon, Nov 17, 2008 at 11:21:09AM -0800, H. Peter Anvin wrote: >> We've discussed that in private at the time, and recently on LKML too. >> In summary: >> I'm fine with that, and so is everybody I talked to (including Linus), >> except Greg KH who vetoed it since he believes the code is irrevocably >> and contagiously evil. >> > > Signed-off-by is about copyright, it's not a review issue. It means "I > certify that I know that the author had the rights to submit this code." > Code quality is important but separate. Indeed; so what were Greg KH's complaints, specifically? Were they a code review issue or was just complaining about the anonymity issue? (Note that Shem has also been willing to disclose is identity to someone who would be willing/able to vouch that he's a real person, and so we would have just as much legal traceability back to him as any other piece of code which was submitted with a Signed-off-by.) - Ted |