#20 numerous compilation warnings - errors

[Jan Schmidt]

Unused typedefs and functions

src/torc/bitstream/Virtex4.cpp 497, 595, 662, 722: error: typedef ‘word_t’ locally defined but not used
src/torc/bitstream/Virtex5.cpp 698, 808, 890, 959: error: typedef ‘word_t’ locally defined but not used
src/torc/bitstream/Virtex6.cpp 699, 810, 896, 965: error: typedef ‘word_t’ locally defined but not used
src/torc/bitstream/Virtex7.cpp 891, 1003, 1089, 1157error: typedef ‘word_t’ locally defined but not used
src/torc/bitstream/VirtexBitstream.cpp:373:44: error: typedef ‘FrameAddressToIndex’ locally defined but not used
src/torc/bitstream/VirtexBitstream.cpp:374:44: error: typedef ‘FrameIndexToAddress’ locally defined but not used
src/torc/bitstream/VirtexBitstream.cpp:372:39: error: typedef ‘FrameAddress’ locally defined but not used
src/torc/generic/ParameterMap.cpp:93:52: error: typedef ‘DataMap’ locally defined but not used
src/torc/generic/edif/Decompiler.cpp:797:54: error: typedef ‘Params’ locally defined but not used
src/torc/generic/edif/Decompiler.cpp:1024:53: error: typedef ‘Params’ locally defined but not used
src/torc/generic/edif/Decompiler.cpp:37:13: error: ‘std:: cxx11::string {anonymous}::trimLeading(const string&)’ defined but not used
src/torc/router/NetRouterHeuristicUnitTest.cpp:35:41: error: typedef ‘ExtendedWireInfo’ locally defined but not used
src/torc/router/TraceNodeUnitTest.cpp:32:28: error: typedef ‘Arc’ locally defined but not used

Wrong syntax (never allowed?)
src/torc/generic/Flattening.cpp:709:24: error: redeclaration of ‘template<class _pointer=""> std::__cxx11::string torc::generic::getModifiedName(const string&, const _Pointer&, const std::vector<long unsigned="" int="">&)’ may not have default arguments
src/torc/generic/Flattening.cpp:715:24: error: redeclaration of ‘template<class _pointer=""> std::__cxx11::string torc::generic::getRenamedName(const InstanceSharedPtr&, const _Pointer&, const std::vector<long unsigned="" int="">&)’ may not have default arguments </long></class></long></class>

src/torc/placer/Placement.hpp:

1. missing #include <iostream>, </iostream>
2. why huge inline functions?

replace BOOST_MESSAGE by BOOST_TEST_MESSAGE
src/torc/packer/XdlUnpackUnitTest.cpp:36:75: error: ‘BOOST_MESSAGE’ was not declared in this scope
src/torc/router/NetRouterUnitTest.cpp:53:28: error: ‘BOOST_MESSAGE’ was not declared in this scope
src/torc/router/TraceUnitTest.cpp:46:28: error: ‘BOOST_MESSAGE’ was not declared in this scope

[Jan Schmidt]

Forgot: gcc 5.3.1, boost 1.60.0, SUSE Tumbleweed 42

[Neil Steiner]

As with issue #19, Torc's compilation flags may be too strict for newer versions of GCC and Boost. You can look at this page to see some of the combinations of GCC and Boost that we have tested, or you can try relaxing the compiler settings on lines 53+ of torc/trunk/src/torc/Makefile.targets by removing -Werror and/or -Wall.

As for src/torc/placer/Placement.hpp, the placer should be considered experimental. Note that member functions defined in a header are not necessarily inlined: Inlining is up to the compiler's discretion unless explicitly specified.