From: Raj <sou...@ra...> - 2005-03-21 03:33:28
|
Nathan Neulinger wrote: > On Tue, 2005-03-15 at 22:17 -0800, Mike Johnson wrote: > >>yeah, i'm not sure. i think it'd be necessary to create the database >>with an NLS value and install a language pack. >> >>i tried to insert some poems from here using the otlv.h from cvs: >> >>http://www.columbia.edu/kermit/utf8.html >> >>but i get "ORA-12704: character set mismatch". so i'm not sure what i'd >>have to do... >> >>i can send you a patch, but be warned... it includes a reformat of >>tooracleconnection.h. it's amazing how your understanding of code can be >>changed while you reformat it. :-) > > > I'm open to committing these, if we can get a reasonable consensus that > the resulting format is acceptable to the main developers. > I've been looking at the otl changes too since I finally traced bug 1115326 (Some datatypes are not fully supported) to otl. It seems the newer version of otl (4.0.109+) have incorporated the nvarchar and nchar types.. we'd be working silly trying to back-port the changes. I like the suggestion of incorporating the latest version of otl and working backwards to eliminate any bugs by changing our code, not otl, to maintain compatibility with future versions of otl as well.. --Raj. > >>On Tue, 2005-03-15 at 21:33 -0600, Nathan Neulinger wrote: >> >>>Is it sufficient to just create a table with NVARCHAR() columns filled >>>with some double-byte characters to test this? >>> >>>What does the success/failure look like? >>> >>>-- Nathan >>> >>>On Sat, 2005-03-12 at 16:46 -0800, Henrik (Mauritz) Johnson wrote: >>> >>>>Did you apply my UTF8 updates? If not, are you using a database with non >>>>ASCII7 data while testing it? Also the small change I made that the >>>>default datatype is char if not known adds support for some datatypes >>>>that will fail with the original OTL. >>>> >>>>/Mauritz >>>> >>>>Mike Johnson wrote: >>>> >>>> >>>>>alexey, are you working on this by any chance? i pulled down otlv.h and >>>>>got it to compile stock with some minor tora changes. i also had to >>>>>disable the parse(toConnectionSub *sub,const QCString &sql) function in >>>>>tooracleconnection.cpp, but a grep of the source makes me think it's not >>>>>really used. >>>>> >>>>>i'm using it against 8i right now without any problems. i've opened most >>>>>of the tools and debugged a couple procs. cancel works, too. i'm also >>>>>downloading the instant client to see if that'll work, just to be >>>>>thorough. >>>>> >>>>>in looking at diff from the original otlv.h and henrik's, i'm not sure >>>>>what else to check. there are _no_ comments anywhere as to why something >>>>>was added or removed, so i'm not sure if i need to merge anything at all >>>>>given that it's working for me. >>>>> >>>>>what do you think of my committing what i have and we'll test on our >>>>>platforms? it seems to be the only way to check it... >>>>> >>>>>On Fri, 2005-02-25 at 14:20 +0000, Alexey Danilchenko wrote: >>>>> >>>>> >>>>> >>>>>>Actually after scanning the current version of OTL - there seems to be >>>>>>the cancel() functionality there already (can't say which OTL version >>>>>>introduced it). I will take a look at the upgrading OTL once I'll finish >>>>>>with the getting TOra build for Windows with QT Free port. >>>>>> >>>>>>Alexey >>>>>> >>>>>>Henrik (Mauritz) Johnson wrote: >>>>>> >>>>>> >>>>>> >>>>>> >>>>>>>Just so you guys know the OTL that is used in TOra is not the stock >>>>>>>4.0.70, the original should be in there somewhere though so you can >>>>>>>get a diff with my changes. Off the top of my head I seem to remember >>>>>>>having added support for more datatypes (Although the author has >>>>>>>probably run past me on that now). Better support for UTF-8 and also I >>>>>>>seem to remember having added cancel. I've tried getting this stuff >>>>>>>into the original OTL release but I have not had that much luck with >>>>>>>that. >>>>>>> >>>>>>>/Mauritz >>>>>>> >>>>>>>Alexey Danilchenko wrote: >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>>>Looking at the recent changes which included OTL updates I thought >>>>>>>>I'll mention this. >>>>>>>> >>>>>>>>It might be a good idea to update OTL version used in TOra with the >>>>>>>>newer one. The OTL author (Sergei) is fixing bugs in a fast pace and >>>>>>>>current OTL version (4.0.107) is far ahead of what TOra uses (4.0.70). >>>>>>>> >>>>>>>>Generally it might be a good idea to have some plan on updating OTL >>>>>>>>versions in TOra on a regular basis. >>>>>>>> >>>>>>>>I have been dealing with Sergei before and he is open to suggestions >>>>>>>>and fixes reported bugs in a jiffy. So I would suggest that we don't >>>>>>>>fix any OTL bugs ourselves but report them to Sergei (OTL project) >>>>>>>>and wait for the new OTL release. >>>>>>>> >>>>>>>>What do you guys think? >>>>>>>> >>>>>>>>Alexey >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>------------------------------------------------------- >>>>>>>>SF email is sponsored by - The IT Product Guide >>>>>>>>Read honest & candid reviews on hundreds of IT Products from real users. >>>>>>>>Discover which products truly live up to the hype. Start reading now. >>>>>>>>http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click >>>>>>>>_______________________________________________ >>>>>>>>Tora-develop mailing list >>>>>>>>Tor...@li... >>>>>>>>https://lists.sourceforge.net/lists/listinfo/tora-develop >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>>>------------------------------------------------------- >>>>>>SF email is sponsored by - The IT Product Guide >>>>>>Read honest & candid reviews on hundreds of IT Products from real users. >>>>>>Discover which products truly live up to the hype. Start reading now. >>>>>>http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click >>>>>>_______________________________________________ >>>>>>Tora-develop mailing list >>>>>>Tor...@li... >>>>>>https://lists.sourceforge.net/lists/listinfo/tora-develop >>>>>> >>>>>> >>>> >>>> >>>> >>>>------------------------------------------------------- >>>>SF email is sponsored by - The IT Product Guide >>>>Read honest & candid reviews on hundreds of IT Products from real users. >>>>Discover which products truly live up to the hype. Start reading now. >>>>http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click >>>>_______________________________________________ >>>>Tora-develop mailing list >>>>Tor...@li... >>>>https://lists.sourceforge.net/lists/listinfo/tora-develop >>>> |