Re: [Tm4j-developers] [DONE] Make TopicMapProviderFactory a "real" factory

[Harald K. <har...@we...>]

Hi Florian,


> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Hello.
> 
> On Monday 10 November 2003 13:50, Harald Kuhn wrote:
> | > Harald, could you please double-check if the refactoring works with the
> | > JNDIProviderFactory. All I've done is change "implements" to "extends"
> | > and renamed "createTopicMapProvider" to "newTopicMapProvider" (the
> | > createTopicMapProvider() method is still available, it's provided by the
> | > abstract TopicMapProviderFactory for backwards compatibility). It
> | > compiles well in Eclipse, but I must confess I didn't find the Ant target
> | > that must be invoked to build your JNDI-related classes (just noticed
> | > that an hour or so ago). Please update me on that.
> |
> | Matter of fact, there is no ant target (and there will probably never be
> | one). I dont think that we need a special ant target for compiling three
> | additional classes and the installation should only be done by hand, as
> | this is quite critical. The J2EE spec does not provide rules for
> | configuration of the container, so the config procedure is different for
> | every web container. In order to not risk damage on this configuration (by
> | using the wrong procedure) I think, that one should do this manually. I
> | thought about adding the compilation to one of the other targets instead
> | but could not find the time to discuss this with Kal and you all (so please
> | make suggestions).
> 
> Well unless Kal objects, I guess the best option is to just add the 
> org.tm4j.jndi package to the tm4j.sources patternset, so it will be picked up 
> by the tm4j-build target when compiling.

+1

> | By the way, it wont work with the JNDI implementation as the spi
> | ProviderFactory depends on a public NoArgumentConstructor
> | (Class.newInstance()). 
> 
> I'm confused now: The abstract TopicMapProviderFactory *itself* depends on 
> there being a no-arg public constructor in the implementing subclass. So that 
> can't be the problem, and I'm almost sure I'm missing your point. Please 
> clarify. :-)

Sorry, part of this malfunction was my own fault (i got confused about this because i got some exceptions indicating instanciation problems), I got a mixture of "old" and new classes. There are some parts however which (at the moment) wont work without using depcretacted methods. 

E.g. in TMNav you could instanciate a new Provider by giving its factoreis classname (inside a swing textfield during runtime). Also i am still not quite sure how to use different providers together (could you please clarify this ?). To get around this, I see (if you have other suggestions / ideas, please let me know) two different options: we just use the deprecated methods (not very clean in my opinion) or we add another newInstance method to TopicMapProviderFactory where you can specify the classname in a direct way (e.g. newInstance(String className) or newInstace(Properties props)). The second one may be not in line with the "normal facory behavier" (you seem to know more about that than I) but i think it is much cleaner then using deprecated methods.

> | This dependence is also true for TMNav (provider
> | management dialog), panckoucke (the context which is used by TMNav, the
> | TopicMapViewer and probably kamal) and  tmharvest as these use Digester for
> | parsing their xml config files. So these also wont work with the changed
> | tm4j for the time beeing. I have to check with christoph (and maybe niko,
> | if he can find the time) who will do the porting and how to do it.
> 
> OK. I have one more request to you: Could you please run the sources in 
> org.tm4j.jndi through Jalopy, then check them back in? They are really 
> difficult to follow at times, with tabs instead of spaces and missing braces 
> in "else" clauses all over the place. I would be really helpful if that were 
> fixed. :-) 
>
> Later,
> Florian
> 

Cheers 
Harald
______________________________________________________________________________
WEB.DE FreeMail wird 5 Jahre jung! Feiern Sie mit uns und
nutzen Sie die neuen Funktionen http://f.web.de/features/?mc=021130