Re: [Tm4j-developers] Re: TopicMapSource implementation

[Harald K. <har...@we...>]

Hi Kal,
> 
> Hi Harald,
> 
> While I was doing this implementation, I noticed that the addTopicMap()
> methods that take a TopicMapSource are specified on
> TopicMapProviderBase, not on the TopicMapProvider interface, 

I did that on purpose because i wanted to wait with adding the new methods to the Interface until after the ozone "problem" was solved (in order not to break the code to much).

> so I've
> added the declarations to the TopicMapProvider interface. I have also
> created a new class called TopicMapSourceSupport (in the
> org.tm4j.topicmap.source package) which provides the default
> implementations of these methods. So by making TopicMapProviderBase and
> the OzoneTopicMapProviderImpl classes extend TopicMapSourceSupport, I
> can make use of the common base class to provide the handling of
> TopicMapSources.

If we are already on this: I thougth wether it would not be better to move the XML Catalog support into a  Utility class ?! We should probably consult Murray on this ...

> Does that make sense ? 

Defenitly :)

> AFAICS it does, but I just wanted to check that
> there wasn't something subtle that I was missing before doing the
> check-in... :)
> 
> Cheers,

Cheers,
Harald
______________________________________________________________________________
Tippen Sie mit der cleveren Kombination von Zusammen und Alleine. Der neue Weg 
zum Lottoglueck: WEB.DE Spielgemeinschaften! https://spielgemeinschaften.web.de/