Re: [Tm4j-developers] [DONE] Make TopicMapProviderFactory a "real" factory

[Florian G. H. <f.g...@gm...>]

=2D----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello.

On Monday 10 November 2003 13:50, Harald Kuhn wrote:
| > Harald, could you please double-check if the refactoring works with the
| > JNDIProviderFactory. All I've done is change "implements" to "extends"
| > and renamed "createTopicMapProvider" to "newTopicMapProvider" (the
| > createTopicMapProvider() method is still available, it's provided by the
| > abstract TopicMapProviderFactory for backwards compatibility). It
| > compiles well in Eclipse, but I must confess I didn't find the Ant targ=
et
| > that must be invoked to build your JNDI-related classes (just noticed
| > that an hour or so ago). Please update me on that.
|
| Matter of fact, there is no ant target (and there will probably never be
| one). I dont think that we need a special ant target for compiling three
| additional classes and the installation should only be done by hand, as
| this is quite critical. The J2EE spec does not provide rules for
| configuration of the container, so the config procedure is different for
| every web container. In order to not risk damage on this configuration (by
| using the wrong procedure) I think, that one should do this manually. I
| thought about adding the compilation to one of the other targets instead
| but could not find the time to discuss this with Kal and you all (so plea=
se
| make suggestions).

Well unless Kal objects, I guess the best option is to just add the=20
org.tm4j.jndi package to the tm4j.sources patternset, so it will be picked =
up=20
by the tm4j-build target when compiling.

| By the way, it wont work with the JNDI implementation as the spi
| ProviderFactory depends on a public NoArgumentConstructor
| (Class.newInstance()).=20

I'm confused now: The abstract TopicMapProviderFactory *itself* depends on=
=20
there being a no-arg public constructor in the implementing subclass. So th=
at=20
can't be the problem, and I'm almost sure I'm missing your point. Please=20
clarify. :-)

| This dependence is also true for TMNav (provider
| management dialog), panckoucke (the context which is used by TMNav, the
| TopicMapViewer and probably kamal) and  tmharvest as these use Digester f=
or
| parsing their xml config files. So these also wont work with the changed
| tm4j for the time beeing. I have to check with christoph (and maybe niko,
| if he can find the time) who will do the porting and how to do it.

OK. I have one more request to you: Could you please run the sources in=20
org.tm4j.jndi through Jalopy, then check them back in? They are really=20
difficult to follow at times, with tabs instead of spaces and missing brace=
s=20
in "else" clauses all over the place. I would be really helpful if that wer=
e=20
fixed. :-)=20

Later,
=46lorian

=2D --=20
=46lorian G. Haas <f.g...@gm...> http://member.ycn.com/~fgh/en/

GnuPG key ID: 0x46D00BE3
Key fingerprint: 18B4 3E7B 191E F534 254A  1F7C 816D 950B 46D0 0BE3

My GnuPG key is available from the public PGP key server at
pgp.mit.edu (and various other key servers).

=2D----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE/r8wagW2VC0bQC+MRAm9KAKC6L65yce4ie0MaDO4PA8fN/RBJgwCgsEVx
OwUcLCzYk6eMO15nvq3Ei84=3D
=3DXOE0
=2D----END PGP SIGNATURE-----