RE: [Tm4j-developers] Index interface proposal checked in

[Florian G. H. <f.g...@gm...>]

Kal,

here are a few comments.

1. The fact that the methods returning an IndexMeta object are called
getIndexMeta() in IndexProvider and getIndexMetaData() in IndexManager seems
like an inconsistency to me.

2. Perhaps IndexManager.hasIndex(String) should be renamed to
isRegistered(String) or isRegisteredIndex(String). In addition, I think that
since already have IndexMeta.isAutomaticallyUpdated(), we should also have
an isAutomaticallyOpened() replacing requiresOpen() (with return values
reversed, of course).

3. I think that IndexProvider.getIndexNames() should be renamed to
getIndexClassNames(), or perhaps be amended/replaced by a getIndexClasses()
method returning a Class[] array. A boolean isSupportedIndex(Class
indexClass) method may also be helpful. Or one might go the whole nine yards
and overload close(), getIndex(), getIndexMeta() and open() in such a way
that they also accept an argument of type Class, representing the index
class. The same could be done to the methods in IndexManager.

4. Index.reindex() documents that it throws UnsupportedOperationException
which does not exist.

5. IndexProvider.getIndex() and IndexProvider.close() both document two
exceptions which they do not throw.

6. IndexManager.getIndex() documents one exception which it does not throw.

Hope I'm making sense,
-- Florian


| -----Original Message-----
| From: tm4...@li...
| [mailto:tm4...@li...]On Behalf Of Kal
| Ahmed
| Sent: Donnerstag, 28. Februar 2002 19:18
| To: tm4...@li...
| Subject: RE: [Tm4j-developers] Index interface proposal checked in
|
|
| I have just checked in a cleaned up version of the index interfaces for a
| quick peer review before I start coding some implementations of
| this stuff.
|
| All comments welcome.
|
| Cheers,
|
| Kal