From: Kal A. <ka...@te...> - 2001-07-19 14:39:29
|
Hi Gerd, What you describe sounds like a generic "import" method for the TopicMapProvider interface - essentially a way for an application programmer to easily code the task of parsing an XTM file and storing it in whatever underlying topic map store is being used by the system. Is that correct ? If so, I'm not sure that TopicMapProvider is necessarily the right place to add this functionality - generic import and export interfaces would definitely be useful and the TopicMapManager interface makes it relatively easy to implement, but I think I would prefer to have a separate interface for store-independant and syntax-independant import/export - I am thinking that in the future it would be good to reintroduce support for reading and possibly writing ISO 13250 syntax and for reading and possibly writing Ontopia's LTM syntax. For that reason I would prefer to encapsulate import and export in some interface(s) separate from TopicMapProvider. What do you think ? On the subject of TopicImpl.m_contribThemes and TopicMapImpl.m_id - both are dead code...well spotted! I've removed them from my local copy and I'll check-in in a short while. Cheers, Kal > -----Original Message----- > From: tm4...@li... > [mailto:tm4...@li...]On Behalf Of Gerd > Mueller > Sent: 17 July 2001 18:56 > To: tm4...@li... > Subject: [Tm4j-developers] TopicMapProvider > > > > Hi, > > I'm about to implement the TopicMapProvider stuff for ozone. What > I'm missing is something like a createTopicMap() method. I would > suggest to extend the TopicMapProvider interface with the > following method: > > public TopicMap buildTopicMap( InputSource input, > TopicMap existingTopicMap ) throws TopicMapProviderException; > > This method parses the input source and either creates a new > TopicMap if existingTopicMap is null or merges it otherwise. > I'm not sure about the baseURL of the new TopicMap: Should it > created automatically by the provider or can it be user defined ? > > Best Regards, > Gerd > > P.S. While browsing the code I found TopicImpl.m_contribThemes. Is > this still necessary ? Otherwise I would suggest to remove it. Also > TopicMapImpl has a member m_id although it already inherits one > from TopicMapObjectImpl. > > -- > ________________________________________________________________ > Gerd Mueller ge...@sm... > SMB GmbH http://www.smb-tec.com > > _______________________________________________ > Tm4j-developers mailing list > Tm4...@li... > http://lists.sourceforge.net/lists/listinfo/tm4j-developers > > |