From: Xuan B. <med...@us...> - 2008-01-21 19:21:12
|
Update of /cvsroot/tm4j/tm4j/src/org/tm4j/topicmap/tmdm/basic In directory sc8-pr-cvs10.sourceforge.net:/tmp/cvs-serv12342/src/org/tm4j/topicmap/tmdm/basic Modified Files: BasicTopic.java Log Message: Spelling fix: s/wether/whether/ (found thanks to a code-review by Benjamin Bock <bb-...@bo...>) Index: BasicTopic.java =================================================================== RCS file: /cvsroot/tm4j/tm4j/src/org/tm4j/topicmap/tmdm/basic/BasicTopic.java,v retrieving revision 1.1 retrieving revision 1.2 diff -C2 -d -r1.1 -r1.2 *** BasicTopic.java 21 Jan 2008 11:13:44 -0000 1.1 --- BasicTopic.java 21 Jan 2008 19:21:15 -0000 1.2 *************** *** 29,33 **** (Thus, we can pack more topics in RAM and we are faster at disk accesses (and we should be faster even when only doing RAM accesses, as RAM is nowadays slower than CPUs).) ! The methods for adding and removing items to these sets currently return wether they succeeded. Possibly they should just always return void (or throw exceptions in case of failure), if reporting success makes other implementations inefficient or harder to implement. --- 29,33 ---- (Thus, we can pack more topics in RAM and we are faster at disk accesses (and we should be faster even when only doing RAM accesses, as RAM is nowadays slower than CPUs).) ! The methods for adding and removing items to these sets currently return whether they succeeded. Possibly they should just always return void (or throw exceptions in case of failure), if reporting success makes other implementations inefficient or harder to implement. *************** *** 45,49 **** /** While rolesPlayed is specified in TMDM, it is redundant from a data completeness point of view. ! Wethere a Topic plays an AssociationRole in a particular Association can be determined by looking at the AssociationRoles of that Association. Thus, as BasicTopic should only provide a backend (and should not provide indexing functionality), one may actually consider not implementing --- 45,49 ---- /** While rolesPlayed is specified in TMDM, it is redundant from a data completeness point of view. ! Whethere a Topic plays an AssociationRole in a particular Association can be determined by looking at the AssociationRoles of that Association. Thus, as BasicTopic should only provide a backend (and should not provide indexing functionality), one may actually consider not implementing |