Menu

#56 Compilation failure if !defined (TCL_THREADS)

open
nobody
None
5
2015-04-16
2015-04-16
No

In tls.c (ll. 154-155), init_mx and initialized are only declared if TCL_THREADS is defined; however, at ll. 1719 et seq., they are always used. Consequently, attempting to compile against a single-threaded core fails:

tls.c: In function ‘TlsLibInit’:
tls.c:1719:10: error: ‘initialized’ undeclared (first use in this function)
     if (!initialized) {
          ^
tls.c:1719:10: note: each undeclared identifier is reported only once for each function it appears in
Makefile:252: recipe for target 'tls.o' failed
make: *** [tls.o] Error 1

The minimal fix is always to declare them. Patch attached.

J.

1 Attachments

Discussion